Allow to customize blobovnicza's leaf width #622

dstepanov-yadro · 2023-08-18T06:27:53Z

dstepanov-yadro commented

2023-08-18 06:27:53 +00:00

Relates #602

Now it is possible to set custom width for the blobovnizca's leaves. It allows to have more databases with same depth and do not increase the number of active blobovnizcas.

In turn, this will allow to create smaller blobovnizcas with the same target blobovnizca tree size to reduce degradation.

Relates #602 Now it is possible to set custom width for the blobovnizca's leaves. It allows to have more databases with same depth and do not increase the number of active blobovnizcas. In turn, this will allow to create smaller blobovnizcas with the same target blobovnizca tree size to reduce degradation.

dstepanov-yadro requested review from storage-core-committers 2023-08-18 06:31:22 +00:00

dstepanov-yadro requested review from storage-core-developers 2023-08-18 06:31:23 +00:00

acid-ant reviewed 2023-08-18 07:05:55 +00:00

pkg/local_object_storage/blobstor/blobovniczatree/blobovnicza.go Outdated

					
				@ -124,2 +128,3 @@

					for i := uint64(0); i < blz.blzShallowDepth; i++ {

						cp *= blz.blzShallowWidth

						if i+1 == blz.blzShallowDepth {

							activeMapCapacity *= blz.blzLeafWidth

acid-ant commented

2023-08-18 07:05:55 +00:00

It is possible to multiply out of the loop, in this case if will be redundant. In this case, condition for iteration will be i < blz.blzShallowDepth-1

It is possible to multiply out of the loop, in this case `if` will be redundant. In this case, condition for iteration will be `i < blz.blzShallowDepth-1`

dstepanov-yadro commented

2023-08-18 07:35:17 +00:00

Since this is an unsigned data type (uint64), I prefer not to deal with subtraction:)