TrueCloudLab/frostfs-node

`TestCounters` is flaky #633

New issue

Closed

opened 2023-08-21 17:21:14 +00:00 by fyrchik · 4 comments

fyrchik commented

2023-08-21 17:21:14 +00:00

Owner

Probably a bug in tests rather than in node, but lets check.

https://git.frostfs.info/TrueCloudLab/frostfs-node/actions/runs/1140/jobs/2

--- FAIL: TestCounters (18.28s)
    --- FAIL: TestCounters/Delete (12.46s)
        metrics_test.go:189: 
            	Error Trace:	/workspace/TrueCloudLab/frostfs-node/pkg/local_object_storage/shard/metrics_test.go:189
            	Error:      	Not equal: 
            	            	expected: 0x8
            	            	actual  : 0x6
            	Test:       	TestCounters/Delete
FAIL

Probably a bug in tests rather than in node, but lets check. https://git.frostfs.info/TrueCloudLab/frostfs-node/actions/runs/1140/jobs/2 ``` --- FAIL: TestCounters (18.28s) --- FAIL: TestCounters/Delete (12.46s) metrics_test.go:189: Error Trace: /workspace/TrueCloudLab/frostfs-node/pkg/local_object_storage/shard/metrics_test.go:189 Error: Not equal: expected: 0x8 actual : 0x6 Test: TestCounters/Delete FAIL ```

fyrchik added the

labels 2023-08-21 17:21:14 +00:00

fyrchik added this to the v0.37.0 milestone 2023-08-21 17:21:19 +00:00

fyrchik self-assigned this 2023-08-23 07:32:10 +00:00

fyrchik commented

2023-08-23 07:43:51 +00:00

Author

Owner

In https://git.frostfs.info/TrueCloudLab/frostfs-node/actions/runs/1140/jobs/3 we have a data race, which is in shard delete -- that may be the culprit.

In https://git.frostfs.info/TrueCloudLab/frostfs-node/actions/runs/1140/jobs/3 we have a data race, which is in shard delete -- that may be the culprit.

fyrchik referenced this issue from a pull request that will close it,

2023-08-23 07:45:03 +00:00

shard: Fix data race in metrics tests #637

fyrchik added a new dependency 2023-08-23 07:45:50 +00:00

#637 shard: Fix data race in metrics tests

fyrchik removed a dependency 2023-08-23 07:46:01 +00:00

#637 shard: Fix data race in metrics tests

fyrchik closed this issue

2023-08-23 10:26:14 +00:00

fyrchik commented

2023-10-02 08:45:25 +00:00

Author

Owner

https://git.frostfs.info/TrueCloudLab/frostfs-node/actions/runs/1874/jobs/3

https://git.frostfs.info/TrueCloudLab/frostfs-node/actions/runs/1874/jobs/3

fyrchik reopened this issue

2023-10-02 08:45:26 +00:00

fyrchik modified the milestone from v0.37.0 to v0.38.0

2023-10-02 08:45:38 +00:00

fyrchik commented

2023-10-09 19:00:20 +00:00

Author

Owner

https://git.frostfs.info/TrueCloudLab/frostfs-node/actions/runs/2090/jobs/3

https://git.frostfs.info/TrueCloudLab/frostfs-node/actions/runs/2090/jobs/3

fyrchik referenced this issue

2023-10-11 13:07:00 +00:00

policer: Allow to provide metrics from the outside #735

fyrchik commented

2023-10-11 13:07:13 +00:00

Author

Owner

https://git.frostfs.info/TrueCloudLab/frostfs-node/actions/runs/2131/jobs/3

https://git.frostfs.info/TrueCloudLab/frostfs-node/actions/runs/2131/jobs/3

~~fyrchik referenced this issue 2023-10-31 11:19:52 +00:00~~

shard/test: Fix TestCounters() #771

fyrchik referenced this issue from a pull request that will close it,

2023-10-31 11:20:28 +00:00

shard/test: Fix TestCounters() #771

fyrchik referenced this issue from a commit

2023-10-31 12:53:32 +00:00

[#633] shard/test: Fix race conditions in TestCounters()

fyrchik referenced this issue from a commit

2023-10-31 12:53:32 +00:00

[#633] shard/test: Fix TestCounters()

fyrchik closed this issue

2023-10-31 12:53:32 +00:00

fyrchik referenced this issue

2024-05-07 08:38:30 +00:00

TestObjectCounter is flaky #1122

Sign in to join this conversation.

No labels

good first issue

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#633

No description provided.