Refactor traversing container nodes in services #643

New Issue

Open

opened 2023-08-24 08:03:06 +00:00 by fyrchik · 0 comments

fyrchik commented

2023-08-24 08:03:06 +00:00

Owner

Put and PutSingle need to do the same job, but there is code duplication.
We have ugly mExclude map to not process any node twice, this could be incorporated in to traverser.
"additional broadcast" looks like a kludge -- we need to iterate all nodes, let's do it once -- this flag can be moved to the traverser.
Get and search do the same thing, let's try to reuse the same code.

After this:

All parallelization becomes easier (see #225)
We can discuss moving placement.Traverser to SDK.

1. Put and PutSingle need to do the same job, but there is code duplication. 2. We have ugly `mExclude` map to not process any node twice, this could be incorporated in to traverser. 3. "additional broadcast" looks like a kludge -- we need to iterate all nodes, let's do it once -- this flag can be moved to the traverser. 4. Get and search do the same thing, let's try to reuse the same code. After this: 1. All parallelization becomes easier (see #225) 2. We can discuss moving placement.Traverser to SDK.