TrueCloudLab/frostfs-node

Refactor traversing container nodes in services #643

New issue

Open

opened 2023-08-24 08:03:06 +00:00 by fyrchik · 0 comments

fyrchik commented

2023-08-24 08:03:06 +00:00

Owner

Put and PutSingle need to do the same job, but there is code duplication.
We have ugly mExclude map to not process any node twice, this could be incorporated in to traverser.
"additional broadcast" looks like a kludge -- we need to iterate all nodes, let's do it once -- this flag can be moved to the traverser.
Get and search do the same thing, let's try to reuse the same code.

After this:

All parallelization becomes easier (see #225)
We can discuss moving placement.Traverser to SDK.

1. Put and PutSingle need to do the same job, but there is code duplication. 2. We have ugly `mExclude` map to not process any node twice, this could be incorporated in to traverser. 3. "additional broadcast" looks like a kludge -- we need to iterate all nodes, let's do it once -- this flag can be moved to the traverser. 4. Get and search do the same thing, let's try to reuse the same code. After this: 1. All parallelization becomes easier (see #225) 2. We can discuss moving placement.Traverser to SDK.

fyrchik added the

labels 2023-08-24 08:03:06 +00:00

fyrchik self-assigned this 2023-08-24 08:03:10 +00:00

fyrchik referenced this issue from a commit

2023-08-24 10:36:01 +00:00

[#643] objsvc/put: Copy config to `distributedTarget`

fyrchik referenced this issue from a commit

2023-08-24 10:36:01 +00:00

[#643] objsvc/put: Unify placement iterators

fyrchik referenced this issue from a commit

2023-08-24 10:36:01 +00:00

[#643] objsvc/put: Unify extraBroadcastEnabled usage

fyrchik added this to the v0.38.0 milestone 2023-08-25 09:50:54 +00:00

fyrchik modified the milestone from v0.38.0 to v0.39.0

2024-02-12 06:34:11 +00:00

fyrchik modified the milestone from v0.39.0 to v0.40.0

2024-05-14 14:19:00 +00:00

fyrchik modified the milestone from v0.40.0 to v0.41.0

2024-06-01 09:19:48 +00:00

fyrchik modified the milestone from v0.41.0 to v0.42.0

2024-06-14 07:07:01 +00:00

fyrchik modified the milestone from v0.42.0 to v0.43.0

2024-07-23 06:34:44 +00:00

fyrchik modified the milestone from v0.43.0 to v0.44.0

2024-09-30 11:51:36 +00:00

Sign in to join this conversation.

No labels

good first issue

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#643

No description provided.