TrueCloudLab/frostfs-node

Simplify iteration via common.Storage interface #655

New issue

Closed

opened 2023-08-28 11:01:15 +00:00 by fyrchik · 0 comments

fyrchik commented

2023-08-28 11:01:15 +00:00

Owner

Look at these ifs

if err != nil {

We have multiple usage for iterate:

"normal" one
Best-effort, when errors are ignored
Lazy when object is fetched only when needed.

This complicates implementations and user code (what parameters should I choose? What errors are ignored?)

Look at these ifs https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/9072772a09c93f2bcdb9ad1441344512980a4a39/pkg/local_object_storage/writecache/writecachebbolt/flush.go#L196 We have multiple usage for iterate: 1. "normal" one 2. Best-effort, when errors are ignored 3. Lazy when object is fetched only when needed. This complicates implementations _and_ user code (what parameters should I choose? What errors are ignored?)

fyrchik added the

labels 2023-08-28 11:01:15 +00:00

fyrchik changed title from ~~Simplify common.Storage interface~~ to Simplify iteration via common.Storage interface

2023-08-28 11:01:25 +00:00

fyrchik added this to the v0.38.0 milestone 2023-08-28 14:25:18 +00:00

dstepanov-yadro self-assigned this 2023-11-15 10:03:39 +00:00

dstepanov-yadro referenced this issue from a pull request that will close it,

2023-11-15 11:21:31 +00:00

Refactor storage iterator #807

dstepanov-yadro closed this issue

2023-11-17 07:11:57 +00:00

dstepanov-yadro referenced this issue from a commit

2023-11-17 07:11:58 +00:00

[#655] storage: Drop `LazyHandler`

dstepanov-yadro referenced this issue from a commit

2023-11-17 07:11:58 +00:00

[#655] storage: Drop `ErrorHandler`

Sign in to join this conversation.

No labels

good first issue

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#655

No description provided.