TrueCloudLab
/
frostfs-node
19
1
Fork 20
Code Issues 93 Pull Requests 9 Actions Releases Activity

Simplify iteration via common.Storage interface #655

New Issue
Closed
opened 2023-08-28 11:01:15 +00:00 by fyrchik · 0 comments
fyrchik commented 2023-08-28 11:01:15 +00:00
Owner

Look at these ifs
9072772a09/pkg/local_object_storage/writecache/writecachebbolt/flush.go (L196)

We have multiple usage for iterate:

  1. "normal" one
  2. Best-effort, when errors are ignored
  3. Lazy when object is fetched only when needed.

This complicates implementations and user code (what parameters should I choose? What errors are ignored?)

Look at these ifs https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/9072772a09c93f2bcdb9ad1441344512980a4a39/pkg/local_object_storage/writecache/writecachebbolt/flush.go#L196 We have multiple usage for iterate: 1. "normal" one 2. Best-effort, when errors are ignored 3. Lazy when object is fetched only when needed. This complicates implementations _and_ user code (what parameters should I choose? What errors are ignored?)
fyrchik added the
discussion
frostfs-node
triage
 labels 2023-08-28 11:01:15 +00:00
fyrchik changed title from Simplify common.Storage interface to Simplify iteration via common.Storage interface 2023-08-28 11:01:25 +00:00
fyrchik added this to the v0.38.0 milestone 2023-08-28 14:25:18 +00:00
dstepanov-yadro self-assigned this 2023-11-15 10:03:39 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
fix/cli_control_targets
master
support/v0.38
support/v0.37
support/v0.36
support/v0.34
support/v0.30
support/v0.27
v0.39.0
v0.38.6
v0.38.5
v0.38.4
v0.38.3
v0.38.2
v0.38.1
v0.38.0
v0.38.0-rc.2
v0.38.0-rc.1
v0.37.0
v0.37.0-rc.1
v0.36.0
v0.34.0
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
badger

Badger DB related issues   
frostfs-adm
   
frostfs-cli
   
frostfs-ir
   
frostfs-lens
   
frostfs-node
   
good first issue

Good for newcomers   
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
v0.38.0
Assignees
Clear assignees
No Assignees
dstepanov-yadro
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#655
There is no content yet.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?