node: Bind length of copies number to number of replicas #665

acid-ant · 2023-08-30T10:46:06Z

acid-ant commented

2023-08-30 10:46:06 +00:00

Allow to use one digit in copies number array for backward compatibility.

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Allow to use one digit in copies number array for backward compatibility. Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>

acid-ant force-pushed bugfix/compare-copies-num-with-rep from 7e668a79f6 to aef2bc4244

2023-08-30 10:46:51 +00:00

Compare

acid-ant requested review from storage-core-committers 2023-08-30 11:08:29 +00:00

acid-ant requested review from storage-core-developers 2023-08-30 11:08:29 +00:00

fyrchik approved these changes 2023-08-30 12:13:35 +00:00

pkg/services/object_manager/placement/traverser.go Outdated

					
				@ -76,1 +76,4 @@

					cnLen := len(cfg.copyNumbers)

					if cnLen > 0 && cnLen != 1 && cnLen != cfg.policy.NumberOfReplicas() {

						return nil, errors.New("copies number accepts only one number or array with length " +

fyrchik commented

2023-08-30 12:12:54 +00:00

What about a defining a constant error (like errNilBuilder?

What about a defining a constant error (like `errNilBuilder`?

acid-ant commented

2023-08-30 12:23:43 +00:00

Why not, added.

fyrchik marked this conversation as resolved

pkg/services/object_manager/placement/traverser_test.go Outdated

					
				@ -232,4 +232,2 @@

							expectedRem: replicas,

						},

						{

							name:        "compatible zero copy numbers, len 2",

fyrchik commented

2023-08-30 12:13:32 +00:00

Do we have INcompatible tests?

acid-ant commented

2023-08-30 12:25:26 +00:00

No, let's create them. Updated.

fyrchik marked this conversation as resolved

acid-ant force-pushed bugfix/compare-copies-num-with-rep from aef2bc4244 to 63942ae2be

2023-08-30 12:23:29 +00:00

Compare

fyrchik approved these changes 2023-08-30 17:11:47 +00:00

fyrchik merged commit fe5aa06a75 into master

2023-08-30 17:11:59 +00:00

fyrchik referenced this pull request from a commit

2023-08-30 17:12:02 +00:00

[#665] node: Bind length of copies number to number of replicas

Sign in to join this conversation.

No reviewers

TrueCloudLab/storage-core-developers

No labels

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#665