TrueCloudLab/frostfs-node

[#667] writecache: Add logs for report error func in tests #689

Merged

fyrchik merged 1 commit from aarifullin/frostfs-node:feature/667-cache_unittest_logs into master

2023-09-14 17:02:55 +00:00

aarifullin commented

2023-09-14 11:13:17 +00:00

Member

This pull-request does not resolve the bug for the issue but because the test is flaky and it is hard to reproduce it locally I suggested this might help to trace the error

This pull-request does not resolve the bug for [the issue](https://git.frostfs.info/TrueCloudLab/frostfs-node/issues/667) but because the test is flaky and it is hard to reproduce it locally I suggested this [might](https://git.frostfs.info/TrueCloudLab/frostfs-node/issues/667#issuecomment-21728) help to trace the error

aarifullin requested review from storage-core-committers 2023-09-14 11:14:41 +00:00

aarifullin requested review from storage-core-developers 2023-09-14 11:14:49 +00:00

fyrchik reviewed 2023-09-14 11:55:27 +00:00

pkg/local_object_storage/writecache/writecachebadger/flush_test.go Outdated

					
				@ -33,2 +36,3 @@

						return WithReportErrorFunc(func(string, error) {

						return WithReportErrorFunc(func(msg string, err error) {

							cnt.Add(1)

							testlogger.Debug("Report error func: "+msg, zap.Error(err))

fyrchik commented

2023-09-14 11:55:27 +00:00

Owner

Why this Report error func: prefix? I think we might just use Warn with error_counter field, as we already do in the engine.

Why this `Report error func:` prefix? I think we might just use `Warn` with `error_counter` field, as we already do in the engine.

aarifullin commented

2023-09-14 12:04:15 +00:00

Author

Member

Alright. Let's use Warn message without the prefix. Fixed

Alright. Let's use `Warn` message without the prefix. Fixed

fyrchik marked this conversation as resolved

aarifullin force-pushed feature/667-cache_unittest_logs from 437e5fa5ca to b31d1a108d

2023-09-14 12:03:54 +00:00

Compare

acid-ant approved these changes 2023-09-14 12:08:27 +00:00

fyrchik approved these changes 2023-09-14 15:24:15 +00:00

fyrchik merged commit 3889e829e6 into master

2023-09-14 17:02:55 +00:00

Sign in to join this conversation.

No reviewers

TrueCloudLab/storage-core-developers

No labels

good first issue

No milestone

No project

No assignees

3 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#689

No description provided.