Sort items by default in frostfs-cli output #694

elebedeva · 2023-09-18T07:21:07Z

elebedeva commented

2023-09-18 07:21:07 +00:00

Close #333

Signed-off-by: Ekaterina Lebedeva ekaterina.lebedeva@yadro.com

Close #333 Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>

elebedeva requested review from storage-core-developers 2023-09-18 07:22:19 +00:00

elebedeva requested review from storage-core-committers 2023-09-18 07:22:21 +00:00

dstepanov-yadro commented

2023-09-18 08:03:31 +00:00

The task was about all the commands, but not specifically about shards list. I suggest we consider a more global solution.

The task was about all the commands, but not specifically about `shards list`. I suggest we consider a more global solution.

elebedeva changed title from ~~Sort items by shard ID in frostfs-cli output~~ to WIP: Sort items by shard ID in frostfs-cli output

2023-09-18 08:24:33 +00:00

elebedeva force-pushed sort-output from bb668977e0 to 5841e163fc

2023-09-20 15:29:55 +00:00

Compare

elebedeva force-pushed sort-output from 5841e163fc to 394458fa92

2023-09-25 07:05:48 +00:00

Compare

elebedeva changed title from ~~WIP: Sort items by shard ID in frostfs-cli output~~ to Sort items by shard ID in frostfs-cli output

2023-09-25 07:06:50 +00:00

aarifullin reviewed 2023-09-25 08:03:39 +00:00

cmd/frostfs-cli/internal/client/client.go Outdated

					
				@ -72,0 +78,4 @@

						tmp2 := make([]byte, 32)

						list[i].Encode(tmp1)

						list[j].Encode(tmp2)

						return bytes.Compare(tmp1, tmp2) < 0

aarifullin commented

2023-09-25 08:03:39 +00:00

I suppose

func(i, j int) bool {
  lhs, rhs := list[i].EncodeToString(), list[j].EncodeToString()
  return strings.Compare(lhs, rhs) < 0
}

could be much simpler.

Also, I recommend to use lhs, rhs names instead tmp1, tmp2 - these names are common for the such functors

I suppose ```golang func(i, j int) bool { lhs, rhs := list[i].EncodeToString(), list[j].EncodeToString() return strings.Compare(lhs, rhs) < 0 } ``` could be much simpler. Also, I recommend to use `lhs, rhs` names instead `tmp1, tmp2` - these names are common for the such functors

elebedeva commented

2023-09-25 08:32:50 +00:00

fixed

aarifullin marked this conversation as resolved

elebedeva force-pushed sort-output from 394458fa92 to b8c3c2486d

2023-09-25 08:31:29 +00:00

Compare

elebedeva changed title from ~~Sort items by shard ID in frostfs-cli output~~ to Sort items by default in frostfs-cli output

2023-09-25 11:52:00 +00:00

aarifullin approved these changes 2023-09-25 11:52:46 +00:00

dstepanov-yadro approved these changes 2023-09-25 11:59:19 +00:00

dstepanov-yadro requested review from acid-ant 2023-09-25 12:00:14 +00:00