TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 101 Pull requests 5 Projects Releases 1 Activity Actions

metrics: add metric to evaluate the policer performance #720

Merged
fyrchik merged 1 commit from elebedeva/frostfs-node:metrics-policer into master 2023-10-09 19:02:11 +00:00
Conversation 0 Commits 1 Files changed 6 +44
elebedeva commented 2023-10-04 16:33:37 +00:00
Member
Copy link

Close #701

Signed-off-by: Ekaterina Lebedeva ekaterina.lebedeva@yadro.com

Close #701 Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>
elebedeva changed title from WIP: metrics: add metric to evaluate the policer performance to metrics: add metric to evaluate the policer performance 2023-10-05 13:18:09 +00:00
elebedeva requested review from storage-core-committers 2023-10-05 13:18:26 +00:00
elebedeva requested review from storage-core-developers 2023-10-05 13:18:27 +00:00
fyrchik approved these changes 2023-10-05 13:21:25 +00:00
fyrchik left a comment
Owner
Copy link

Could you add policer: or metrics: prefix to the commit message?

Could you add `policer:` or `metrics:` prefix to the commit message?
👍 1
elebedeva force-pushed metrics-policer from 16a6893bc3 to b588174efc 2023-10-05 13:24:49 +00:00 Compare
elebedeva force-pushed metrics-policer from b588174efc to cbd4cb355e 2023-10-05 15:06:09 +00:00 Compare
dstepanov-yadro requested changes 2023-10-05 15:19:06 +00:00
pkg/metrics/policer.go Outdated
@ -0,0 +19,4 @@
Namespace: namespace,
Subsystem: policerSubsystem,
Name: "processed_objects_total",
Help: "Total number of objects processed by policier",
dstepanov-yadro commented 2023-10-05 15:18:32 +00:00
Member
Copy link

Typo: policier -> policer

Typo: policier -> policer
👍 1
fyrchik commented 2023-10-06 06:35:10 +00:00
Owner
Copy link

On peut le considérer comme un policier.

On peut le considérer comme un policier.
😕 1
elebedeva commented 2023-10-09 07:01:39 +00:00
Author
Member
Copy link

fixed

fixed
elebedeva force-pushed metrics-policer from cbd4cb355e to e0ce2adbce 2023-10-09 07:00:32 +00:00 Compare
elebedeva requested review from dstepanov-yadro 2023-10-09 07:02:05 +00:00
dstepanov-yadro approved these changes 2023-10-09 10:14:58 +00:00
fyrchik merged commit 5e229dc248 into master 2023-10-09 19:02:11 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
dstepanov-yadro
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#720
No description provided.
Delete branch "elebedeva/frostfs-node:metrics-policer"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?