TrueCloudLab/frostfs-node

node: React on `SIGHUP` only when node in `READY` state #748

Merged

fyrchik merged 1 commit from acid-ant/frostfs-node:bugfix/49-node-stuck-middle into master

2023-10-24 15:55:30 +00:00

acid-ant commented

2023-10-20 06:55:11 +00:00

Member

Close #49

Add more info in logs when node is going to shut down,
but initialization process still in progress.

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Close #49 Add more info in logs when node is going to shut down, but initialization process still in progress. Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>

acid-ant force-pushed bugfix/49-node-stuck-middle from 6f8d3ae0be to 7605e4e3af

2023-10-20 06:55:43 +00:00

Compare

acid-ant requested review from storage-core-committers 2023-10-20 06:55:44 +00:00

acid-ant requested review from storage-core-developers 2023-10-20 06:56:08 +00:00

fyrchik approved these changes 2023-10-20 07:14:30 +00:00

cmd/frostfs-node/control.go Outdated

					
				@ -92,0 +99,4 @@

				func (c *cfg) swapHealthStatus(st control.HealthStatus) (old control.HealthStatus) {

					old = control.HealthStatus(c.healthStatus.Swap(int32(st)))

					if c.metricsCollector != nil {

fyrchik commented

2023-10-20 07:14:28 +00:00

Owner

Can metricsCollector be nil?

Can `metricsCollector` be nil?

acid-ant commented

2023-10-20 07:46:00 +00:00

Author

Member

In theory yes, but with this method calling it is already initialized.

In theory yes, but with this method calling it is already initialized.

fyrchik commented

2023-10-20 10:19:27 +00:00

Owner

We already use it in multiple places without nil check and, as you said, it is always initialized, let's drop the nil check?

We already use it in multiple places without nil check and, as you said, it is always initialized, let's drop the nil check?

acid-ant commented

2023-10-20 10:48:13 +00:00

Author

Member

Agree, removed.

Agree, removed.

acid-ant force-pushed bugfix/49-node-stuck-middle from 7605e4e3af to 7d27913789

2023-10-20 10:47:57 +00:00

Compare

acid-ant force-pushed bugfix/49-node-stuck-middle from 7d27913789 to 635640282f

2023-10-20 10:48:47 +00:00

Compare

aarifullin approved these changes 2023-10-23 12:56:29 +00:00

fyrchik approved these changes 2023-10-24 15:54:46 +00:00

fyrchik approved these changes 2023-10-24 15:55:06 +00:00

fyrchik merged commit b0cf100427 into master

2023-10-24 15:55:30 +00:00

acid-ant referenced this pull request

2023-12-12 10:56:59 +00:00

SIGHUP should be thread-safe #855

Sign in to join this conversation.

No reviewers

No labels

good first issue

No milestone

No project

No assignees

3 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#748

No description provided.