TrueCloudLab/frostfs-node

Fork 27

Add metrics for logical size #763

New issue

Closed

opened 2023-10-30 11:35:04 +00:00 by fyrchik · 4 comments

fyrchik commented

2023-10-30 11:35:04 +00:00

Owner

container_size_bytes should have a label kind=physical/kind=logical
container_objects_total should have label cid (and kind too)
May be we could reuse objects_total metric with shard label, but imo it is better as container_objects_total -- they are used for different purposes.

`container_size_bytes` should have a label `kind=physical`/`kind=logical` `container_objects_total` should have label `cid` (and kind too) May be we could reuse `objects_total` metric with shard label, but imo it is better as container_objects_total -- they are used for different purposes.

fyrchik added the

discussion

frostfs-node

observability

labels 2023-10-30 11:35:04 +00:00

fyrchik added this to the v0.38.0 milestone 2023-10-31 10:34:53 +00:00

dstepanov-yadro self-assigned this 2023-10-31 17:26:16 +00:00

dstepanov-yadro removed their assignment 2023-10-31 17:26:25 +00:00

dstepanov-yadro self-assigned this 2023-10-31 17:26:38 +00:00

dstepanov-yadro commented

2023-10-31 17:34:04 +00:00

Member

@fyrchik does some migration procedure required? Now logical size is stored.

Also am i right that container_objects_total is new metric? Now only object per shard are awailable.

@fyrchik does some migration procedure required? Now logical size is stored. Also am i right that `container_objects_total` is new metric? Now only object per shard are awailable.

fyrchik commented

2023-11-01 07:31:21 +00:00

Author

Owner

What migration do you have in mind? We already store logical capacity of a container
We could also store physical one.

container_objects_total is a new metric

What migration do you have in mind? We already store logical capacity of a container We could also store physical one. `container_objects_total` is a new metric

fyrchik commented

2023-11-01 07:37:32 +00:00

Author

Owner

We need logical sizes for hard quotes, let's just do container_objects_total now

We need logical sizes for hard quotes, let's just do `container_objects_total` now

dstepanov-yadro commented

2023-11-01 17:19:03 +00:00

Member

@fyrchik How about renaming kind label with physical and logical values in the new metric container_objects_total to, for example, available=true/false.

For example, if container have 5 objects, but 2 of them are inhumed, now counters will be

container_objects_total {kind=physical} 5
container_objects_total {kind=logical} 3

After change it will be

container_objects_total {available=true} 3
container_objects_total {available=false} 2

So available=true counter equals kind=logical counter, available=false = kind=physical - kind=logical

@fyrchik How about renaming `kind` label with `physical` and `logical` values in the new metric `container_objects_total` to, for example, `available=true/false`. For example, if container have 5 objects, but 2 of them are inhumed, now counters will be ``` container_objects_total {kind=physical} 5 container_objects_total {kind=logical} 3 ``` After change it will be ``` container_objects_total {available=true} 3 container_objects_total {available=false} 2 ``` So `available=true` counter equals `kind=logical` counter, `available=false` = `kind=physical` - `kind=logical`

dstepanov-yadro referenced this issue from a pull request that will close it,

2023-11-01 17:55:15 +00:00

Add container objects counter #778

fyrchik closed this issue

2023-11-08 10:44:05 +00:00

fyrchik referenced this issue from a commit

2023-11-08 10:44:06 +00:00

[#763] metabase: Add container objects counter

fyrchik referenced this issue from a commit

2023-11-08 10:44:06 +00:00

[#763] metrics: Add container_objects_total metric