TrueCloudLab
/
frostfs-node
18
1
Fork 20
Code Issues 88 Pull Requests 8 Actions Releases Activity

Estimate compression #766

Merged
fyrchik merged 1 commits from dstepanov-yadro/frostfs-node:feat/compressible into master 2023-11-01 10:08:28 +00:00
Conversation 0 Commits 1 Files Changed 11
dstepanov-yadro commented 2023-10-31 08:23:00 +00:00
Collaborator

Closes #754

Now it is possible to use compression estimation if config has this option enabled.

It should reduce CPU and memory usage in case of the uncompressible objects.

Benchmarks are here: #754 (comment)

Closes #754 Now it is possible to use compression estimation if config has this option enabled. It should reduce CPU and memory usage in case of the uncompressible objects. Benchmarks are here: https://git.frostfs.info/TrueCloudLab/frostfs-node/issues/754#issuecomment-24880
dstepanov-yadro force-pushed feat/compressible from af8c053722 to 2cd9654caf 2023-10-31 11:47:17 +00:00 Compare
dstepanov-yadro force-pushed feat/compressible from 2cd9654caf to 6fd70b013f 2023-10-31 12:06:41 +00:00 Compare
dstepanov-yadro force-pushed feat/compressible from 6fd70b013f to c7d2872d3c 2023-10-31 12:07:29 +00:00 Compare
dstepanov-yadro changed title from WIP to WIP: Estimate compression 2023-10-31 12:23:23 +00:00
fyrchik reviewed 2023-10-31 12:55:03 +00:00
cmd/frostfs-node/config/engine/config_test.go Outdated
@ -84,3 +84,4 @@
require.Equal(t, true, sc.Compress())
require.Equal(t, []string{"audio/*", "video/*"}, sc.UncompressableContentTypes())
require.Equal(t, true, sc.EstimateCompressibility())
fyrchik commented 2023-10-31 12:54:50 +00:00
Owner

Do we need 2 parameters here? I mean we can use anything >=1.0 to disable and 0.9 by default.

Do we need 2 parameters here? I mean we can use anything >=1.0 to disable and 0.9 by default.
dstepanov-yadro commented 2023-10-31 14:16:14 +00:00
Poster
Collaborator

I prefer separate explicit parameters.

I prefer separate explicit parameters.
fyrchik commented 2023-11-01 08:28:55 +00:00
Owner

My thoughts here we that we have compress: bool feature already and this is merely a parameter. compress: false, estimate_compressibility: true is possible, but somewhat invalid state.

My thoughts here we that we have `compress: bool` feature already and this is merely a parameter. `compress: false, estimate_compressibility: true` is possible, but somewhat invalid state.
dstepanov-yadro force-pushed feat/compressible from c7d2872d3c to eda51f8324 2023-10-31 14:31:15 +00:00 Compare
dstepanov-yadro force-pushed feat/compressible from eda51f8324 to 1548b70154 2023-10-31 14:38:11 +00:00 Compare
dstepanov-yadro changed title from WIP: Estimate compression to Estimate compression 2023-10-31 15:10:30 +00:00
dstepanov-yadro requested review from storage-core-committers 2023-10-31 15:11:11 +00:00
dstepanov-yadro requested review from storage-core-developers 2023-10-31 15:11:11 +00:00
acid-ant approved these changes 2023-11-01 06:13:04 +00:00
fyrchik reviewed 2023-11-01 07:43:27 +00:00
cmd/frostfs-node/config.go Outdated
@ -108,1 +108,3 @@
compress bool
compress bool
estimateCompressibility bool
estimateCompressibilityThreshold float64
fyrchik commented 2023-11-01 07:41:49 +00:00
Owner

docs/storage-node-configuration.md needs to be changed too.

`docs/storage-node-configuration.md` needs to be changed too.
dstepanov-yadro commented 2023-11-01 08:25:21 +00:00
Poster
Collaborator

Done

Done
fyrchik marked this conversation as resolved
cmd/frostfs-node/config/engine/shard/config.go Outdated
@ -43,6 +46,30 @@ func (x *Config) UncompressableContentTypes() []string {
"compression_exclude_content_types")
}
// EstimateCompressibility returns the value of "estimate_compressability" config parameter.
fyrchik commented 2023-11-01 07:39:29 +00:00
Owner

Why is it named compress_i_bility in code, but compress_a_bility in config? I haven't seen variant with 'a' TBH

Why is it named `compress_i_bility` in code, but `compress_a_bility` in config? I haven't seen variant with 'a' TBH
dstepanov-yadro commented 2023-11-01 08:25:15 +00:00
Poster
Collaborator

Fixed

Fixed
fyrchik marked this conversation as resolved
config/example/node.env Outdated
@ -113,6 +113,8 @@ FROSTFS_STORAGE_SHARD_0_METABASE_MAX_BATCH_DELAY=10ms
### Blobstor config
FROSTFS_STORAGE_SHARD_0_COMPRESS=true
FROSTFS_STORAGE_SHARD_0_COMPRESSION_EXCLUDE_CONTENT_TYPES="audio/* video/*"
FROSTFS_STORAGE_SHARD_0_ESTIMATE_COMPRESSABILITY=true
fyrchik commented 2023-11-01 07:40:26 +00:00
Owner

Also, what about using COMPRESSION prefix? Like COMPRESSION_EXCLUDE_TYPES, we could later move it in a separate section.

Also, what about using `COMPRESSION` prefix? Like `COMPRESSION_EXCLUDE_TYPES`, we could later move it in a separate section.
dstepanov-yadro commented 2023-11-01 08:25:08 +00:00
Poster
Collaborator

Done

Done
fyrchik marked this conversation as resolved
dstepanov-yadro force-pushed feat/compressible from 1548b70154 to c80b46fad3 2023-11-01 08:24:59 +00:00 Compare
fyrchik approved these changes 2023-11-01 08:29:16 +00:00
fyrchik merged commit c80b46fad3 into master 2023-11-01 10:08:28 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
badger

Badger DB related issues   
frostfs-adm
   
frostfs-cli
   
frostfs-ir
   
frostfs-lens
   
frostfs-node
   
good first issue

Good for newcomers   
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#766
There is no content yet.
Delete Branch "dstepanov-yadro/frostfs-node:feat/compressible"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?