Fix epoch metric #773
Labels
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No Milestone
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-node#773
Loading…
Reference in New Issue
There is no content yet.
Delete Branch "dstepanov-yadro/frostfs-node:fix/epoch_metric"
Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?
metricsCollector
was assigned before initialization, so epoch metric wasn't updated.Closes #764
@ -561,3 +560,4 @@
c.shared = initShared(appCfg, key, netState, relayOnly)
netState.metrics = c.metricsCollector
So we partially initialize
netState
because we need it ininitShared
and then finalizenetState
initialization.The same problem with metrics can happen inside
initShared
To me the problem is that initialization order in code does not match real order.
What about initializing metrics first somewhere? Or is it too much work?
shared
holds metrics, so looks like metrics are initialized correctly. AlsocfgNetmap
holdsnetstate
, so it also looks ok for me. So i don't think it should be refactored.6a91c18f78
to616aafc494