Improve working with IR control service #787

New Issue

Closed

opened 2023-11-07 10:21:33 +00:00 by fyrchik · 1 comment

fyrchik commented

2023-11-07 10:21:33 +00:00

Owner

Currently we use a tricky formula to generate VUB for the transactions. This means, that there will be unfortunate situations when half of the nodes send the tx with one VUB, and other half with a different one.
The suggestion is to:

Make ir control service return calculated VUB for sent transactions (we currently send many, but they all have the same vub)
Allow to override generation with a constant.

So on the first node we do

$ frostfs-cli control ir ...
...
VUB is 12345

And on all other nodes just frostfs-cli control ir --vub 12345 ...

Currently we use a tricky formula to generate VUB for the transactions. This means, that there _will_ be unfortunate situations when half of the nodes send the tx with one VUB, and other half with a different one. The suggestion is to: 1. Make ir control service return calculated VUB for sent transactions (we currently send many, but they all have the same vub) 2. Allow to override generation with a constant. So on the first node we do ``` $ frostfs-cli control ir ... ... VUB is 12345 ``` And on all other nodes just `frostfs-cli control ir --vub 12345 ...`

fyrchik added the

enhancement

frostfs-cli

frostfs-ir

labels 2023-11-07 10:21:33 +00:00

fyrchik commented

2023-11-07 10:22:47 +00:00

Poster

Owner

This is not backwards compatible, maybe we could use --generate-vub explicitly, it will pick the best possible VUB then (just current height + MaxValidUntilBlockIncrement, without rounding formula)

This is not backwards compatible, maybe we could use `--generate-vub` explicitly, it will pick the best possible VUB then (just current height + MaxValidUntilBlockIncrement, without rounding formula)

fyrchik added this to the v0.38.0 milestone 2023-11-07 10:22:50 +00:00