TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 100 Pull requests 4 Projects Releases 1 Activity Actions

Fix protoc and staticcheck version #792

Merged
fyrchik merged 2 commits from dstepanov-yadro/frostfs-node:feat/makefile_deps into master 2023-11-09 10:09:15 +00:00
Conversation 0 Commits 2 Files changed 11 +46 -17
dstepanov-yadro commented 2023-11-08 12:47:10 +00:00
Member
Copy link

Now protoc (also protogen and protoc-gen-go) and staticcheck versions are fixed in Makefile.

Now protoc (also protogen and protoc-gen-go) and staticcheck versions are fixed in `Makefile`.
dstepanov-yadro force-pushed feat/makefile_deps from 2661289eca to 8f8f52d6c0 2023-11-08 12:48:27 +00:00 Compare
dstepanov-yadro force-pushed feat/makefile_deps from 8f8f52d6c0 to 0899e93f72 2023-11-08 12:49:25 +00:00 Compare
dstepanov-yadro reviewed 2023-11-08 12:50:33 +00:00
Makefile Outdated
@ -27,3 +31,3 @@
sed "s/-/~/")-${OS_RELEASE}
OUTPUT_LINT_DIR ?= $(shell pwd)/bin
OUTPUT_LINT_DIR ?= $(abspath $(BIN))/linters
dstepanov-yadro commented 2023-11-08 12:50:33 +00:00
Author
Member
Copy link

To remove whole directory in case of make lint-install

To remove whole directory in case of `make lint-install`
dstepanov-yadro changed title from WIP: Fix protoc and staticcheck version to Fix protoc and staticcheck version 2023-11-08 13:19:39 +00:00
dstepanov-yadro requested review from storage-core-committers 2023-11-08 13:20:51 +00:00
dstepanov-yadro requested review from storage-core-developers 2023-11-08 13:20:51 +00:00
aarifullin approved these changes 2023-11-08 13:22:45 +00:00
fyrchik reviewed 2023-11-08 13:31:13 +00:00
Makefile Outdated
@ -189,7 +215,6 @@ version:
# Delete built artifacts
clean:
rm -rf vendor
fyrchik commented 2023-11-08 13:24:00 +00:00
Owner
Copy link

Why this change?

Why this change?
dstepanov-yadro commented 2023-11-08 13:40:56 +00:00
Author
Member
Copy link

vendor was created by protoc target, i deleted this step, so looks like no vendor directory should exist.

`vendor` was created by protoc target, i deleted this step, so looks like no vendor directory should exist.
👍 1
fyrchik marked this conversation as resolved
Makefile Outdated
@ -97,0 +107,4 @@
@rm -rf $(PROTOBUF_DIR)
@mkdir $(PROTOBUF_DIR)
@echo "⇒ Installing protoc... "
@wget -q -O $(PROTOBUF_DIR)/protoc-$(PROTOC_VERSION)-linux-x86_64.zip 'https://github.com/protocolbuffers/protobuf/releases/download/v$(PROTOC_VERSION)/protoc-$(PROTOC_VERSION)-linux-x86_64.zip'
fyrchik commented 2023-11-08 13:23:29 +00:00
Owner
Copy link

Not a practical concern, but what will happen if I want to develop on windows or macOS?

Not a practical concern, but what will happen if I want to develop on windows or macOS?
👀 1
dstepanov-yadro commented 2023-11-08 14:28:53 +00:00
Author
Member
Copy link

Added macOS support. There will be a bunch of other problems on Windows except protobuf generate:)

Added macOS support. There will be a bunch of other problems on Windows except protobuf generate:)
fyrchik marked this conversation as resolved
dstepanov-yadro force-pushed feat/makefile_deps from 0899e93f72 to 24ff7b7076 2023-11-08 14:27:09 +00:00 Compare
dstepanov-yadro force-pushed feat/makefile_deps from 24ff7b7076 to 066c05905a 2023-11-08 14:30:47 +00:00 Compare
acid-ant approved these changes 2023-11-08 14:49:48 +00:00
achuprov approved these changes 2023-11-08 14:53:23 +00:00
dstepanov-yadro force-pushed feat/makefile_deps from 066c05905a to b4ebde61f6 2023-11-08 15:27:56 +00:00 Compare
fyrchik approved these changes 2023-11-09 09:51:43 +00:00
fyrchik merged commit 7cdae4f660 into master 2023-11-09 10:09:15 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
acid-ant
achuprov
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#792
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:feat/makefile_deps"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?