client: Refactor PrmInit, PrmDial usage #809

aarifullin · 2023-11-15T12:31:14Z

aarifullin commented

2023-11-15 12:31:14 +00:00

Update frostfs-sdk-go version in go.mod and refactor deprecated setters

Update frostfs-sdk-go version in `go.mod` and refactor deprecated setters

aarifullin added the

refactoring

label 2023-11-15 12:31:14 +00:00

aarifullin force-pushed feature/prm_init_prm_dial from f25072a063 to cee0a0fc83

2023-11-15 12:31:48 +00:00

Compare

aarifullin requested review from storage-core-committers 2023-11-15 12:32:38 +00:00

fyrchik approved these changes 2023-11-15 13:09:04 +00:00

pkg/network/cache/multi.go

													
				@ -65,2 +60,4 @@

						prmInit.Key = *x.opts.Key

					}

					prmDial := client.PrmDial{

fyrchik commented

2023-11-15 13:08:54 +00:00

Why was this moved?

aarifullin commented

2023-11-15 13:40:06 +00:00

Poster

Which line are you interested about?

I have intended to make these initializations sequential and more dense: firstly - prmInit, then prmDial

Which line are you interested about? I have intended to make these initializations sequential and more _dense_: firstly - `prmInit`, then `prmDial`

dstepanov-yadro commented

2023-11-15 15:01:59 +00:00

But prmInit has initialization step at line 85:

prmInit.ResponseInfoCallback = x.opts.ResponseCallback

But `prmInit` has initialization step at line 85: ``` prmInit.ResponseInfoCallback = x.opts.ResponseCallback ```

fyrchik commented

2023-11-15 15:16:49 +00:00

My bad, it is the declaration, which was at the first line previously.

My bad, it is _the declaration_, which was at the first line previously.

aarifullin requested review from storage-core-committers 2023-11-15 13:37:04 +00:00

aarifullin requested review from storage-core-developers 2023-11-15 13:37:05 +00:00

fyrchik approved these changes 2023-11-15 15:16:56 +00:00

elebedeva approved these changes 2023-11-16 00:03:57 +00:00

dstepanov-yadro approved these changes 2023-11-16 07:08:53 +00:00

acid-ant approved these changes 2023-11-16 12:49:21 +00:00

fyrchik merged commit 02454df14a into master

2023-11-17 13:37:05 +00:00

fyrchik referenced this issue from a commit

2023-11-17 13:37:06 +00:00

[#809] client: Refactor PrmInit, PrmDial usage

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

5 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#809