Unify config parameter names #822

dstepanov-yadro · 2023-11-21T10:21:51Z

dstepanov-yadro commented

2023-11-21 10:21:51 +00:00

storage.shard.gc.expired_collector_workers_count -> expired_collector_worker_count
storage.shard.writecache.workers_number -> flush_worker_count
object.put.pool_size_remote -> remote_pool_size
object.put.pool_size_local -> local_pool_size

Not used in dev-env.

Closes #715

``` storage.shard.gc.expired_collector_workers_count -> expired_collector_worker_count storage.shard.writecache.workers_number -> flush_worker_count object.put.pool_size_remote -> remote_pool_size object.put.pool_size_local -> local_pool_size ``` Not used in dev-env. Closes #715

dstepanov-yadro requested review from storage-core-committers 2023-11-21 10:31:45 +00:00

dstepanov-yadro requested review from storage-core-developers 2023-11-21 10:31:45 +00:00

fyrchik approved these changes 2023-11-22 07:19:42 +00:00

cmd/frostfs-node/config/engine/shard/writecache/config.go Outdated

													
				@ -113,3 +113,3 @@

					c := config.IntSafe(

						(*config.Config)(x),

						"workers_number",

						"worker_count",

fyrchik commented

2023-11-22 07:19:40 +00:00

While we are here, what about flush_worker_count? @TrueCloudLab/storage-core-developers @TrueCloudLab/storage-core-committers

While we are here, what about `flush_worker_count`? @TrueCloudLab/storage-core-developers @TrueCloudLab/storage-core-committers

acid-ant commented

2023-11-22 08:20:15 +00:00

Vote for flush_worker_count.

Vote for `flush_worker_count`.

👍 1

dstepanov-yadro commented

2023-11-22 14:14:14 +00:00

Poster

done

dstepanov-yadro force-pushed fix/config_parameters from 2dc34acf4b to 07390ad4e3

2023-11-22 14:14:11 +00:00

Compare

acid-ant approved these changes 2023-11-22 14:17:37 +00:00

fyrchik merged commit 07390ad4e3 into master

2023-11-23 07:19:47 +00:00

Sign in to join this conversation.

No reviewers

TrueCloudLab/storage-core-developers

No Label

No Milestone

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#822