TrueCloudLab
/
frostfs-node
19
1
Fork 20
Code Issues 93 Pull Requests 9 Actions Releases Activity

Add pre-commit framework #83

Merged
fyrchik merged 6 commits from fyrchik/frostfs-node:add-pre-commit into master 2023-03-13 07:07:31 +00:00
Conversation 0 Commits 6 Files Changed 38
fyrchik commented 2023-03-07 05:56:51 +00:00
Owner
There is no content yet.
fyrchik force-pushed add-pre-commit from a71353abea to 5334fe5f6c 2023-03-07 06:07:33 +00:00 Compare
fyrchik requested review from storage-core-committers 2023-03-07 06:09:40 +00:00
fyrchik requested review from storage-core-developers 2023-03-07 06:09:40 +00:00
fyrchik added the due date 2023-03-07 2023-03-07 06:09:57 +00:00
carpawell approved these changes 2023-03-09 16:42:53 +00:00
.dockerignore Outdated
@ -6,3 +6,3 @@
.dockerignore
docker
docker
carpawell commented 2023-03-09 16:38:33 +00:00
Collaborator

empty line added? can't get it via that web interface

empty line added? can't get it via that web interface
fyrchik commented 2023-03-09 20:19:41 +00:00
Poster
Owner

Empty line removed.

Empty line removed.
carpawell marked this conversation as resolved
.golangci.yml Outdated
@ -53,4 +55,3 @@ linters:
- whitespace
disable-all: true
fast: false
carpawell commented 2023-03-09 16:41:16 +00:00
Collaborator

what was here?

what was here?
fyrchik commented 2023-03-09 20:20:08 +00:00
Poster
Owner

Empty line removed.

Empty line removed.
carpawell marked this conversation as resolved
fyrchik force-pushed add-pre-commit from 5334fe5f6c to b7661a9c00 2023-03-09 20:19:08 +00:00 Compare
fyrchik requested review from carpawell 2023-03-09 20:20:12 +00:00
fyrchik removed review request for carpawell 2023-03-09 20:20:13 +00:00
fyrchik requested review from carpawell 2023-03-09 20:20:15 +00:00
fyrchik modified the due date from 2023-03-07 to 2023-03-10 2023-03-09 20:27:20 +00:00
acid-ant approved these changes 2023-03-10 10:45:19 +00:00
carpawell approved these changes 2023-03-10 15:00:50 +00:00
fyrchik merged commit bce5827f64 into master 2023-03-13 07:07:31 +00:00
fyrchik deleted branch add-pre-commit 2023-03-13 07:07:31 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
carpawell
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
badger

Badger DB related issues   
frostfs-adm
   
frostfs-cli
   
frostfs-ir
   
frostfs-lens
   
frostfs-node
   
good first issue

Good for newcomers   
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

2023-03-10

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#83
There is no content yet.
Delete Branch "fyrchik/frostfs-node:add-pre-commit"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?