Revise Control API for local override managing #839

New issue

Closed

opened 2023-12-04 07:53:51 +00:00 by aarifullin · 4 comments

aarifullin commented

2023-12-04 07:53:51 +00:00

Member

The current request body for AddChainLocalOverrideRequest means we are able to set local overrides only for containers excepting other targets like namespace. It is required to redefine the request body to set these field:

Chain ID (string, can be empty, if a user want to get it generated)
Target (Type: container, namespace, Name: string)
Serialized chain

Also, @alexvanin @ironbee wished to make possible to pass few chains per request instead one, i.e. to pass chain infos like a list

Waits for policy-engine PR#25

The current request body for [AddChainLocalOverrideRequest ](https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/b2c63e57ba/pkg/services/control/service.proto#L425) means we are able to set local overrides only for containers excepting other targets like namespace. It is required to redefine the request body to set these field: - Chain ID (string, can be empty, if a user want to get it generated) - Target (Type: container, namespace, Name: string) - Serialized chain Also, @alexvanin @ironbee wished to make possible to pass few chains per request instead one, i.e. to pass chain infos like a list Waits for [policy-engine PR#25](https://git.frostfs.info/TrueCloudLab/policy-engine/pulls/25)

aarifullin added the

refactoring

label 2023-12-04 07:53:51 +00:00

dkirillov commented

2023-12-04 08:04:47 +00:00

Member

Related to #803

aarifullin self-assigned this 2023-12-05 14:04:30 +00:00

fyrchik added the

frostfs-node

label 2023-12-11 08:01:25 +00:00

aarifullin commented

2023-12-11 08:04:47 +00:00

Author

Member

The issue has been solved in the PR #842

The issue has been solved in the PR [#842](https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/842)

aarifullin closed this issue

2023-12-11 08:04:54 +00:00

dkirillov commented

2023-12-11 08:09:40 +00:00

Member

The issue has been solved in the PR #842

I'm not sure. We still cannot use namespace target with node control api until #820 (see #842 (comment))

> The issue has been solved in the PR [#842](https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/842) I'm not sure. We still cannot use namespace target with node control api until https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/820 (see https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/842#issuecomment-28110)

fyrchik added this to the v0.38.0 milestone 2023-12-22 07:24:02 +00:00

fyrchik reopened this issue

2024-02-19 07:28:09 +00:00

aarifullin commented

2024-02-19 07:33:47 +00:00

Author

Member

The issue has been solved in the PR #842

I'm not sure. We still cannot use namespace target with node control api until #820 (see #842 (comment))

Namespace target can be set within request body: see spec

> > The issue has been solved in the PR [#842](https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/842) > > I'm not sure. We still cannot use namespace target with node control api until https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/820 (see https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/842#issuecomment-28110) Namespace target can be set within request body: see [spec](https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/pkg/services/control/service.proto#L448-L575)

fyrchik closed this issue

2024-02-19 08:04:28 +00:00