Properly instantiate APE request in the object service #844

New Issue

Closed

opened 2023-12-06 08:39:48 +00:00 by aarifullin · 2 comments

aarifullin commented

2023-12-06 08:39:48 +00:00

Collaborator

The current implementation of Request interface omits many details like extracting properties from v2.RequestInfo (it uses empty-string stubs for properties)

It is required to extract values and set properties that are mentioned in native schema

The [current implementation](https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/pkg/services/object/acl/ape_request.go) of [Request](https://git.frostfs.info/TrueCloudLab/policy-engine/src/branch/master/pkg/resource/resource.go) interface omits many details like extracting properties from `v2.RequestInfo` (it uses empty-string stubs for properties) It is required to extract values and set properties that are mentioned in [native schema](https://git.frostfs.info/TrueCloudLab/policy-engine/src/branch/master/schema/native/consts.go#L30)

dkirillov commented

2023-12-06 09:01:46 +00:00

It's also required that request contains object attributes (at least FilePath) to be able to deny access by object name (for example).

It's also required that request contains object attributes (at least `FilePath`) to be able to deny access by object name ([for example](https://git.frostfs.info/dkirillov/frostfs-node/commit/4628c9ba8edbc42820795ecc613e6ffedef97c00)).