TrueCloudLab/frostfs-node

Linter update #857

Merged

dstepanov-yadro merged 4 commits from dstepanov-yadro/frostfs-node:feat/linter_update into master

2024-09-04 19:51:05 +00:00

dstepanov-yadro commented

2023-12-12 07:15:06 +00:00

Member

Updated linter version and added new linters:

Updated linter version and added new linters: * https://github.com/catenacyber/perfsprint * https://github.com/Antonboom/testifylint * https://github.com/ghostiam/protogetter

dstepanov-yadro force-pushed feat/linter_update from 70846d21af to 89a50d99d1

2023-12-12 07:16:31 +00:00

Compare

dstepanov-yadro force-pushed feat/linter_update from 89a50d99d1 to 3700bd443d

2023-12-12 07:23:05 +00:00

Compare

dstepanov-yadro changed title from ~~WIP: Linter update~~ to Linter update

2023-12-12 09:27:37 +00:00

dstepanov-yadro requested review from storage-core-committers 2023-12-12 09:27:48 +00:00

dstepanov-yadro requested review from storage-core-developers 2023-12-12 09:27:49 +00:00

acid-ant approved these changes 2023-12-12 10:48:41 +00:00

fyrchik approved these changes 2023-12-12 11:31:28 +00:00

cmd/frostfs-node/notificator.go Outdated

					
				@ -167,7 +167,6 @@ func connectNats(ctx context.Context, c *cfg) {

					err := c.cfgNotifications.nw.w.Connect(ctx, endpoint)

					if err != nil {

						panic(fmt.Sprintf("could not connect to a nats endpoint %s: %v", endpoint, err))

					} else {

fyrchik commented

2023-12-12 11:07:45 +00:00

Owner

Is it related to the commit (update linter versions)?

Is it related to the commit (`update linter versions`)?

dstepanov-yadro commented

2023-12-12 12:53:21 +00:00

Author

Member

Yes: this fix was found by new version of linter.

Yes: this fix was found by new version of linter.

achuprov approved these changes 2023-12-12 11:34:40 +00:00

dstepanov-yadro force-pushed feat/linter_update from 3700bd443d to 11add38e87

2023-12-12 13:28:07 +00:00

Compare

dstepanov-yadro merged commit 11add38e87 into master

2023-12-12 13:42:59 +00:00

dstepanov-yadro deleted branch feat/linter_update

2023-12-12 13:43:00 +00:00

dstepanov-yadro referenced this pull request from a commit

2023-12-12 13:43:02 +00:00

[#857] Makefile: Update linter version

dstepanov-yadro referenced this pull request from a commit

2023-12-12 13:43:02 +00:00

[#857] golangci: Add perfsprint linter

dstepanov-yadro referenced this pull request from a commit

2023-12-12 13:43:02 +00:00

[#857] golangci: Add testifylint linter

dstepanov-yadro referenced this pull request from a commit

2023-12-12 13:43:02 +00:00

[#857] golangci: Add protogetter linter

Sign in to join this conversation.

No reviewers

No labels

good first issue

No milestone

No project

No assignees

4 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#857

No description provided.