cli: fix mixing CID and container ID #877

Merged

fyrchik merged 1 commit from elebedeva/frostfs-node:cli-output into master

2023-12-19 16:36:28 +00:00

elebedeva commented

2023-12-18 13:00:10 +00:00

Member

Close #717

Replace container ID outputs that may be used in scripts with CID.

Signed-off-by: Ekaterina Lebedeva ekaterina.lebedeva@yadro.com

Close #717 Replace `container ID` outputs that may be used in scripts with `CID`. Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>

elebedeva changed title from ~~Fix mixing CID and container ID~~ to cli: fix mixing CID and container ID

2023-12-18 13:05:27 +00:00

fyrchik commented

2023-12-18 13:14:34 +00:00

Owner

It can be parsed in tests, have you looked through the https://git.frostfs.info/TrueCloudLab/frostfs-testcases/ ?
cc @TrueCloudLab/qa-committers

It can be parsed in tests, have you looked through the https://git.frostfs.info/TrueCloudLab/frostfs-testcases/ ? cc @TrueCloudLab/qa-committers

elebedeva commented

2023-12-18 14:03:58 +00:00

Author

Member

It can be parsed in tests, have you looked through the https://git.frostfs.info/TrueCloudLab/frostfs-testcases/ ?
cc @TrueCloudLab/qa-committers

Yes, container ID is parsed, for example, here but the string from command line is splitted with a separator, so these changes should not cause problems.

> It can be parsed in tests, have you looked through the https://git.frostfs.info/TrueCloudLab/frostfs-testcases/ ? > cc @TrueCloudLab/qa-committers Yes, `container ID` is parsed, for example, [here](https://git.frostfs.info/TrueCloudLab/frostfs-testlib/src/commit/663c14470981bdd1445f182dd0d6dc00c2d83662/src/frostfs_testlib/steps/cli/container.py#L321) but the string from command line is splitted with a separator, so these changes should not cause problems.

🚀 1

elebedeva requested review from storage-core-committers 2023-12-18 14:04:24 +00:00

elebedeva requested review from storage-core-developers 2023-12-18 14:04:24 +00:00