`frostfs-cli` says "missing port in address" when the RPC endpoint is not defined at all #884

New issue

Closed

opened 2023-12-21 10:33:11 +00:00 by an-nikitin · 2 comments

an-nikitin commented

2023-12-21 10:33:11 +00:00

Expected Behavior

When no RPC endpoint is defined in the configuration file, frostfs-cli says something to that effect, ex. "RPC endpoint is not defined".

Current Behavior

When no RPC endpoint is defined in the configuration file, frostfs-cli says: "can't create API client: provided RPC endpoint is incorrect: missing port in address".

Possible Solution

No fix can be suggested by a QA engineer. Further solutions shall be up to developers.

Steps to Reproduce (for bugs)

Create configuration file which does not contain the rpc_endpoint parameter at all.
Run a command like this one: frostfs-cli container create --name test34534 --policy "REP 2" --basic-acl "0FBFBFFF" --await --config

Context

Not a major bug but a little confusing, expecially for novice users who do not yet understand what different endpoints are for (if the control endpoint is present in the file and includes the port number, the error may look like there is something wrong with with that particular endpoint, although there isn't, and the user can waste a lot of time figuring this out).

Regression

No.

Your Environment

Sbercloud.

## Expected Behavior When no RPC endpoint is defined in the configuration file, frostfs-cli says something to that effect, ex. "RPC endpoint is not defined". ## Current Behavior When no RPC endpoint is defined in the configuration file, frostfs-cli says: "can't create API client: provided RPC endpoint is incorrect: missing port in address". ## Possible Solution No fix can be suggested by a QA engineer. Further solutions shall be up to developers. ## Steps to Reproduce (for bugs) 1. Create configuration file which does not contain the rpc_endpoint parameter at all. 2. Run a command like this one: frostfs-cli container create --name test34534 --policy "REP 2" --basic-acl "0FBFBFFF" --await --config <path-to-config-file> ## Context Not a major bug but a little confusing, expecially for novice users who do not yet understand what different endpoints are for (if the control endpoint is present in the file and includes the port number, the error may look like there is something wrong with with that particular endpoint, although there isn't, and the user can waste a lot of time figuring this out). ## Regression No. ## Your Environment Sbercloud.

an-nikitin added the

bug

triage

labels 2023-12-21 10:33:11 +00:00

fyrchik added the

good first issue

frostfs-cli

labels 2023-12-21 10:51:54 +00:00

fyrchik commented

2023-12-21 10:52:10 +00:00

Owner

Let's return more specific error in case the parameter is missing or empty

fyrchik commented

2023-12-21 10:52:29 +00:00

Owner

Don't forger to check both --endpoint (control) and --rpc-endpoint.

Don't forger to check both `--endpoint` (control) and `--rpc-endpoint`.

fyrchik added this to the v0.38.0 milestone 2023-12-22 07:22:10 +00:00

fyrchik changed title from ~~frostfs-cli says "missing port in address" when the RPC endpoint is not defined at all~~ to frostfs-cli says "missing port in address" when the RPC endpoint is not defined at all

2024-01-09 09:23:28 +00:00