TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 101 Pull requests 6 Projects Releases 1 Activity Actions

Add VSCode debug example #892

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-node:feat/devenv into master 2023-12-29 16:38:11 +00:00
Conversation 0 Commits 1 Files changed 14 +517
dstepanov-yadro commented 2023-12-29 11:18:59 +00:00
Member
Copy link

Added example of the debug configuration for VSCode. I hope it will simplify newcomers life.

Added example of the debug configuration for VSCode. I hope it will simplify newcomers life.
dstepanov-yadro force-pushed feat/devenv from fb88c5f675 to 2b00ba74be 2023-12-29 11:19:51 +00:00 Compare
dstepanov-yadro requested review from storage-core-committers 2023-12-29 11:20:01 +00:00
dstepanov-yadro requested review from storage-core-developers 2023-12-29 11:20:04 +00:00
realloc reviewed 2023-12-29 11:33:36 +00:00
Makefile Outdated
@ -236,1 +239,4 @@
dh clean
locode-download:
@wget -q -O ./.cache/locode_db.gz 'https://git.frostfs.info/attachments/a2e8def7-52b6-49f1-89cd-a056712e8e54'
realloc commented 2023-12-29 11:33:36 +00:00
Owner
Copy link

Would it be more efficient to have a variable pointing to a specific version, providing a way to override it, or possibly detecting the latest release available?

Would it be more efficient to have a variable pointing to a specific version, providing a way to override it, or possibly detecting the latest release available?
dstepanov-yadro commented 2023-12-29 12:24:39 +00:00
Author
Member
Copy link

Fixed

Fixed
realloc reviewed 2023-12-29 11:33:46 +00:00
aarifullin approved these changes 2023-12-29 11:40:25 +00:00
aarifullin approved these changes 2023-12-29 11:40:31 +00:00
fyrchik reviewed 2023-12-29 11:49:07 +00:00
README.md Outdated
@ -79,0 +87,4 @@
```
/
├── src
   ├── frostfs-node
fyrchik commented 2023-12-29 11:46:19 +00:00
Owner
Copy link

Gitea shows warnings for unprintable symbols, don'w we have just tabs here?

Gitea shows warnings for unprintable symbols, don'w we have just tabs here?
dstepanov-yadro commented 2023-12-29 12:06:18 +00:00
Author
Member
Copy link

fixed

fixed
fyrchik marked this conversation as resolved
dev/.vscode-example/launch.json Outdated
@ -0,0 +53,4 @@
"FROSTFS_TREE_ENABLED":"true",
"FROSTFS_OBJECT_DELETE_TOMBSTONE_LIFETIME":"10",
"FROSTFS_STORAGE_SHARD_0_WRITECACHE_ENABLED":"true",
"FROSTFS_STORAGE_SHARD_0_WRITECACHE_PATH":"${workspaceFolder}/.cache/storage/wc0",
fyrchik commented 2023-12-29 11:49:04 +00:00
Owner
Copy link

Why is neo-go config in YAML, and IR/storage in ENV strings?

Why is neo-go config in YAML, and IR/storage in ENV strings?
dstepanov-yadro commented 2023-12-29 12:11:38 +00:00
Author
Member
Copy link

This is done so that there are no unnecessary config files, but neo-go doesn't support env-configs.
Also developers can change storage-node and IR settings in .vscode/launch.json and this changes will not be committed.

This is done so that there are no unnecessary `config` files, but `neo-go` doesn't support env-configs. Also developers can change storage-node and IR settings in `.vscode/launch.json` and this changes will not be committed.
fyrchik marked this conversation as resolved
dstepanov-yadro force-pushed feat/devenv from 2b00ba74be to b736357266 2023-12-29 12:05:34 +00:00 Compare
dstepanov-yadro force-pushed feat/devenv from b736357266 to 80d7f19ccf 2023-12-29 12:24:32 +00:00 Compare
fyrchik approved these changes 2023-12-29 12:34:52 +00:00
Makefile
@ -236,1 +240,4 @@
dh clean
locode-download:
@wget -q -O ./.cache/locode_db.gz 'https://git.frostfs.info/TrueCloudLab/frostfs-locode-db/releases/download/${LOCODE_DB_VERSION}/locode_db.gz'
fyrchik commented 2023-12-29 12:34:49 +00:00
Owner
Copy link

Don't we also need to invoke frostfs-cli locode generate?

Don't we also need to invoke `frostfs-cli locode generate`?
dstepanov-yadro commented 2023-12-29 12:52:40 +00:00
Author
Member
Copy link

This is done by: https://git.frostfs.info/TrueCloudLab/frostfs-locode-db/src/branch/master/Makefile

This is done by: https://git.frostfs.info/TrueCloudLab/frostfs-locode-db/src/branch/master/Makefile
fyrchik marked this conversation as resolved
fyrchik approved these changes 2023-12-29 14:15:44 +00:00
fyrchik merged commit d5d3d8badb into master 2023-12-29 16:38:11 +00:00
fyrchik referenced this pull request from a commit 2023-12-29 16:38:13 +00:00
[#892] node: Add VSCode debug example
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#892
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:feat/devenv"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?