Make notary support enabled by default in morph client #905

New Issue

Open

opened 2024-01-11 13:52:18 +00:00 by aarifullin · 0 comments

aarifullin commented

2024-01-11 13:52:18 +00:00

Collaborator

For now notary subsystem is widely used, so, the proposal is to enable notary support by default in morph client constructor.

To make this, we need to invoke EnableNotarySupport in constructor, but at the same it would be better to make this method deprecated to notify client to stop using this invocation explictly.

I suggest to create enableNotarySupport, copy the definition to there and make

// Deprecated: Notary support is enabled by default during client construction.
func (c *Client) EnableNotarySupport(opts ...NotaryOption) error {
  return c.enableNotarySupport(opts...) // also use in the constructor
}

Also, we need to avoid throwing panic-s like here, here etc.
It is required to make morph client non-panic-prone and return error instead panic.

Since, we're getting rid of EnableNotarySupport, we need to indroduce a method to disable the notary support enabled by default:

func (c *Client) DisableNotarySupport() {
  // ...
}

For now notary subsystem is widely used, so, the proposal is to enable [notary](https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/pkg/morph/client/client.go#L63) support by default in morph client [constructor](https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/pkg/morph/client/constructor.go#L93). To make this, we need to invoke [EnableNotarySupport](https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/pkg/morph/client/notary.go#L81-L115) in constructor, but at the same it would be better to make this method `deprecated` to notify client to stop using this invocation explictly. I suggest to create `enableNotarySupport`, copy the definition to there and make ```go // Deprecated: Notary support is enabled by default during client construction. func (c *Client) EnableNotarySupport(opts ...NotaryOption) error { return c.enableNotarySupport(opts...) // also use in the constructor } ``` Also, we need to avoid throwing `panic`-s like [here](https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/pkg/morph/client/notary.go#L152), [here](https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/pkg/morph/client/constructor.go#L95) etc. It is required to make morph client non-panic-prone and return error instead `panic`. Since, we're getting rid of `EnableNotarySupport`, we need to indroduce a method to disable the notary support enabled by default: ```go func (c *Client) DisableNotarySupport() { // ... } ```