Support disabled mode in frostfs-cli control shards set-mode #917
Labels
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No Milestone
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-node#917
Loading…
Reference in New Issue
There is no content yet.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?
EDIT by @fyrchik :
Changing the config has some problems: in particular not being able to easily wait for completion.
control
service command will solve this problem.While we are here, let's also take care about shard-modes.md document.
We should mention possible problems with this appoach: configuration represents the desireable state, thus any restart/SIGHUP will lose control service changes.
We can disable a shard until it gets really disabled, not caring about service changes reset?
It looks like a kludge, because now the "configuration" includes both files on disk and some transient state.
We should also NOT write to the configuration, this defeats the purpose of the configuration.
The kludge is also not needed IMO, we do this purely to simplify usage in some scenarios.
See #945 description for details