TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 105 Pull requests 11 Projects Releases 2 Activity Actions

morph: Introduce switch rpc guarded rpc actor #925

Merged
fyrchik merged 1 commit from aarifullin/frostfs-node:fix/rpc-actor-guard into master 2024-01-25 13:24:18 +00:00
Conversation 1 Commits 1 Files changed 2 +121 -1
aarifullin commented 2024-01-24 12:57:34 +00:00
Member
Copy link
  • Introduce switch rpc guarded rpc actor in morph client
    to prevent using invalidated rpc actor when RPC switch
    happens.
  • Initialize NewContractStorage with SwitchRPCGuardedActor.
* Introduce switch rpc guarded rpc actor in morph client to prevent using invalidated rpc actor when RPC switch happens. * Initialize NewContractStorage with SwitchRPCGuardedActor.
aarifullin force-pushed fix/rpc-actor-guard from 0f7b10552f to 64882a61ee 2024-01-24 12:58:09 +00:00 Compare
aarifullin requested review from storage-core-committers 2024-01-24 13:01:17 +00:00
aarifullin requested review from storage-core-developers 2024-01-24 13:01:23 +00:00
dstepanov-yadro approved these changes 2024-01-24 15:58:12 +00:00
fyrchik reviewed 2024-01-24 16:25:30 +00:00
pkg/morph/client/actor.go Outdated
@ -0,0 +18,4 @@
// it when it is already invalidated. SwitchRPCGuardedActor is used to prevent
// this situation, getting the rpc actor from Client.
type SwitchRPCGuardedActor struct {
actorProvider actorProvider
fyrchik commented 2024-01-24 16:24:10 +00:00
Owner
Copy link

The constructor accepts *Client, but we use actorProvider in field.
Why not use *Client in struct too?

The constructor accepts `*Client`, but we use `actorProvider` in field. Why not use `*Client` in struct too?
aarifullin commented 2024-01-25 07:00:42 +00:00
Author
Member
Copy link

I think this really makes sense because it is better to make programmer prevent using recursive calls (cli.switchRPCGuardedActor.client.switchRPCGuardedActor.client....)

I think this really makes sense because it is better to make programmer prevent using recursive calls (`cli.switchRPCGuardedActor.client.switchRPCGuardedActor.client....`)
fyrchik marked this conversation as resolved
pkg/morph/client/constructor.go Outdated
@ -157,6 +157,8 @@ func New(ctx context.Context, key *keys.PrivateKey, opts ...Option) (*Client, er
}
cli.setActor(act)
cli.switchRPCGuardedActor = NewSwitchRPCGuardedActor(cli)
fyrchik commented 2024-01-24 16:25:23 +00:00
Owner
Copy link

We use it only to provide it to APE storage. Do we need to store this field here? I mean we can always call NewSwitchRPCGuardedActor(cli) if we have client

We use it only to provide it to APE storage. Do we need to store this field here? I mean we can always call `NewSwitchRPCGuardedActor(cli)` if we have client
aarifullin commented 2024-01-25 06:55:14 +00:00
Author
Member
Copy link

Good point

Good point
fyrchik commented 2024-01-24 16:29:51 +00:00
Owner
Copy link

Other than comments, LGTM

Other than comments, LGTM
fyrchik added the
bug
 label 2024-01-24 16:30:03 +00:00
fyrchik added this to the v0.38.0 milestone 2024-01-24 16:30:06 +00:00
acid-ant approved these changes 2024-01-25 11:53:54 +00:00
aarifullin requested review from dstepanov-yadro 2024-01-25 12:54:26 +00:00
aarifullin requested review from acid-ant 2024-01-25 12:54:28 +00:00
aarifullin force-pushed fix/rpc-actor-guard from 64882a61ee to 42859fd920 2024-01-25 12:54:30 +00:00 Compare
fyrchik approved these changes 2024-01-25 13:24:09 +00:00
fyrchik merged commit 1fe7736d92 into master 2024-01-25 13:24:18 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
acid-ant
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.38.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#925
No description provided.
Delete branch "aarifullin/frostfs-node:fix/rpc-actor-guard"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?