Fix container counters metrics removal #941

Merged

dstepanov-yadro merged 2 commits from dstepanov-yadro/frostfs-node:fix/container_counters into master

2024-09-04 19:51:06 +00:00

dstepanov-yadro commented

2024-01-30 09:45:06 +00:00

Member

Relates #938

Scenario:

Policer inhumes objects of removed container, size metric becomes 0
GC removes metric
GC removes physical objects of the removed container and updates metric (sets size=0), metric appears again

Fix:

Do not update metrics if value (size or count) is zero
Delete size records in DB (doesn't relate to bug, but it is bug anyway).

Relates #938 Scenario: 1. Policer inhumes objects of removed container, `size` metric becomes 0 2. GC removes metric 3. GC removes physical objects of the removed container and updates metric (sets `size=0`), metric appears again Fix: 1. Do not update metrics if value (`size` or `count`) is zero 2. Delete size records in DB (doesn't relate to bug, but it is bug anyway).

dstepanov-yadro added 2 commits 2024-01-30 09:45:15 +00:00

[#938 ] engine: Fix container count removal c681354afd

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>

[#938 ] shard: Update only changed counters

DCO action / DCO (pull_request) Successful in 5m40s

Details

Vulncheck / Vulncheck (pull_request) Successful in 5m33s

Details

Tests and linters / Staticcheck (pull_request) Successful in 7m12s

Details

Build / Build Components (1.21) (pull_request) Successful in 7m25s

Details

Build / Build Components (1.20) (pull_request) Successful in 7m29s

Details

Tests and linters / Lint (pull_request) Successful in 8m26s

Details

Tests and linters / Tests (1.20) (pull_request) Successful in 9m48s

Details

Tests and linters / Tests with -race (pull_request) Successful in 9m56s

Details

Tests and linters / Tests (1.21) (pull_request) Successful in 10m10s

Details

675eec91f3

If metric value hasn't changed, but we update metric, then
non existed metric will apear with zero value.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>