Need to add description of healthcheck statuses in --help control command #962

Open
opened 2024-02-06 07:31:00 +00:00 by anikeev-yadro · 1 comment

The meaning of healthcheck status is not clear

root@frostfs-v15-failover-node2:~# sudo frostfs-cli --endpoint 127.0.0.1:8091 -w /etc/frostfs/storage/wallet.json control healthcheck --config /tmp/storage.yaml
Network status: OFFLINE
Health status: READY

Describe the solution you'd like

Need to add description of healthcheck statuses in --help control command

root@frostfs-v15-failover-node2:~# sudo frostfs-cli --endpoint 127.0.0.1:8091 -w /etc/frostfs/storage/wallet.json control healthcheck --config /tmp/storage.yaml --help
Health check for FrostFS storage nodes.

Usage:
  frostfs-cli control healthcheck [flags]

Flags:
      --address string     Address of wallet account
      --endpoint string    Remote node control address (as 'multiaddr' or '<host>:<port>')
  -h, --help               help for healthcheck
  -t, --timeout duration   Timeout for an operation (default 15s)
  -w, --wallet string      Path to the wallet or binary key

Global Flags:
  -c, --config string       Config file (default is $HOME/.config/frostfs-cli/config.yaml)
      --config-dir string   Config directory
  -v, --verbose             Verbose output
## Is your feature request related to a problem? Please describe. The meaning of healthcheck status is not clear ``` root@frostfs-v15-failover-node2:~# sudo frostfs-cli --endpoint 127.0.0.1:8091 -w /etc/frostfs/storage/wallet.json control healthcheck --config /tmp/storage.yaml Network status: OFFLINE Health status: READY ``` ## Describe the solution you'd like Need to add description of healthcheck statuses in `--help` control command ``` root@frostfs-v15-failover-node2:~# sudo frostfs-cli --endpoint 127.0.0.1:8091 -w /etc/frostfs/storage/wallet.json control healthcheck --config /tmp/storage.yaml --help Health check for FrostFS storage nodes. Usage: frostfs-cli control healthcheck [flags] Flags: --address string Address of wallet account --endpoint string Remote node control address (as 'multiaddr' or '<host>:<port>') -h, --help help for healthcheck -t, --timeout duration Timeout for an operation (default 15s) -w, --wallet string Path to the wallet or binary key Global Flags: -c, --config string Config file (default is $HOME/.config/frostfs-cli/config.yaml) --config-dir string Config directory -v, --verbose Verbose output ```
anikeev-yadro added the
triage
label 2024-02-06 07:31:00 +00:00
fyrchik added the
frostfs-node
label 2024-02-12 06:19:11 +00:00
fyrchik added this to the v0.39.0 milestone 2024-02-12 06:19:15 +00:00
fyrchik added
documentation
and removed
triage
labels 2024-02-12 06:19:25 +00:00
fyrchik modified the milestone from v0.39.0 to v0.40.0 2024-05-14 14:06:38 +00:00
fyrchik modified the milestone from v0.40.0 to v0.41.0 2024-06-01 09:19:45 +00:00
fyrchik modified the milestone from v0.41.0 to v0.42.0 2024-06-14 07:06:35 +00:00

I suggest extending the existing document, rather than modifying the help message. Status meaning is a part of gRPC API, not the frostfs-cli.

I suggest extending the existing document, rather than modifying the help message. Status meaning is a part of gRPC API, not the `frostfs-cli`.
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#962
There is no content yet.