Adjust localClient interface to put invokers/actors on top of it #97

New issue

Closed

opened 2023-03-08 23:30:50 +00:00 by snegurochka · 1 comment

snegurochka commented

2023-03-08 23:30:50 +00:00

Member

Original issue: https://github.com/nspcc-dev/neofs-node/issues/2233

I'm always frustrated when I look at the localClient in neofs-adm. It tries to mimic old RPC client APIs and contains a lot of duplicating code inside (and outside where it's used, getCandidateRegisterPrice or nnsIsAvailable for example).

Describe the solution you'd like

It can be slimmed down by implementing enough of API for invokers/actors that we have. Then they will work on top of this local client easily providing contract-specific things.

Describe alternatives you've considered

Keeping it all the way it is now, nothing good here.

Additional context

#2232, the switch there is absolutely useless.

Original issue: https://github.com/nspcc-dev/neofs-node/issues/2233 ## Is your feature request related to a problem? Please describe. I'm always frustrated when I look at the `localClient` in neofs-adm. It tries to mimic old RPC client APIs and contains a lot of duplicating code inside (and outside where it's used, `getCandidateRegisterPrice` or `nnsIsAvailable` for example). ## Describe the solution you'd like It can be slimmed down by implementing enough of API for invokers/actors that we have. Then they will work on top of this local client easily providing contract-specific things. ## Describe alternatives you've considered Keeping it all the way it is now, nothing good here. ## Additional context #2232, the switch there is absolutely useless.

fyrchik added this to the v0.38.0 milestone 2023-05-18 08:42:25 +00:00

fyrchik added the

frostfs-adm

refactoring

labels 2023-10-02 13:20:57 +00:00

fyrchik modified the milestone from v0.38.0 to v0.39.0

2023-10-02 13:20:59 +00:00

fyrchik modified the milestone from v0.39.0 to v0.40.0

2024-05-14 14:17:25 +00:00

fyrchik modified the milestone from v0.40.0 to v0.41.0

2024-06-01 09:19:53 +00:00

fyrchik modified the milestone from v0.41.0 to v0.42.0

2024-06-14 07:09:05 +00:00

fyrchik commented

2024-06-14 10:38:27 +00:00

Owner

It became much better after #750 and neo-go update. The current interface is pretty generic

type Client interface {

and there are almost no custom logic. The exception is awaitTx where we persist changes.

It became much better after https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/750 and neo-go update. The current interface is pretty generic https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/3fc8e0e08c15927620c98b471c8ef05811a3127d/cmd/frostfs-adm/internal/modules/morph/helper/n3client.go#L27 and there are almost no custom logic. The exception is `awaitTx` where we persist changes.

fyrchik closed this issue

2024-06-14 10:38:28 +00:00

fyrchik removed this from the v0.42.0 milestone 2024-06-14 10:43:46 +00:00