TrueCloudLab
/
frostfs-node
19
1
Fork 20
Code Issues 93 Pull Requests 9 Actions Releases Activity

fstree: Use O_TMPFILE for temporary files #970

Merged
fyrchik merged 7 commits from fyrchik/frostfs-node:fix-fstree into master 2024-02-09 16:12:13 +00:00
Conversation 3 Commits 7 Files Changed 9
fyrchik commented 2024-02-08 10:55:20 +00:00
Owner
There is no content yet.
fyrchik force-pushed fix-fstree from 4489f1b054 to 88bce58370 2024-02-08 15:07:00 +00:00 Compare
fyrchik changed title from WIP fstree: Use O_TMPFILE for temporary files to fstree: Use O_TMPFILE for temporary files 2024-02-08 15:07:27 +00:00
fyrchik requested review from storage-core-committers 2024-02-08 15:07:31 +00:00
fyrchik requested review from storage-core-developers 2024-02-08 15:07:42 +00:00
dstepanov-yadro commented 2024-02-08 15:08:33 +00:00
Collaborator

Commit format must be changed

Commit format must be changed
👍 1
fyrchik force-pushed fix-fstree from 88bce58370 to cf5b0c201e 2024-02-08 15:10:48 +00:00 Compare
fyrchik force-pushed fix-fstree from cf5b0c201e to dbbf42bb56 2024-02-08 15:23:27 +00:00 Compare
fyrchik commented 2024-02-08 17:42:02 +00:00
Poster
Owner

Tests pass locally, but the one failing on CI is directly related, so searching for race conditions

Tests pass locally, but the one failing on CI is directly related, so searching for race conditions
fyrchik force-pushed fix-fstree from dbbf42bb56 to 3d9e1ee1cb 2024-02-08 17:59:17 +00:00 Compare
fyrchik commented 2024-02-08 17:59:45 +00:00
Poster
Owner

The problem was that my local tests used +linux tag and CI ones either didn't use it or do not support O_TMPFILE.

The problem was that my local tests used `+linux` tag and CI ones either didn't use it or do not support `O_TMPFILE`.
fyrchik force-pushed fix-fstree from 85e2fe0007 to be45ea0dad 2024-02-08 18:57:10 +00:00 Compare
acid-ant approved these changes 2024-02-09 07:55:54 +00:00
pkg/local_object_storage/blobstor/fstree/fstree_write_linux.go Outdated
@ -0,0 +28,4 @@
}
fd, err := unix.Open(root, flags, uint32(perm))
if err != nil {
return nil // Which means that OS-specific writeData can't be created and FSTre
acid-ant commented 2024-02-09 07:53:04 +00:00
Collaborator

Looks like it needs to be continued.

Looks like it needs to be continued.
fyrchik commented 2024-02-09 13:55:22 +00:00
Poster
Owner

Fixed

Fixed
acid-ant marked this conversation as resolved
fyrchik force-pushed fix-fstree from be45ea0dad to d14d065fdc 2024-02-09 13:55:24 +00:00 Compare
dstepanov-yadro approved these changes 2024-02-09 14:21:49 +00:00
aarifullin approved these changes 2024-02-09 14:43:41 +00:00
fyrchik merged commit b36a453238 into master 2024-02-09 16:12:13 +00:00
fyrchik deleted branch fix-fstree 2024-02-09 16:12:13 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
dstepanov-yadro
aarifullin
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
badger

Badger DB related issues   
frostfs-adm
   
frostfs-cli
   
frostfs-ir
   
frostfs-lens
   
frostfs-node
   
good first issue

Good for newcomers   
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#970
There is no content yet.
Delete Branch "fyrchik/frostfs-node:fix-fstree"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?