TrueCloudLab
/
frostfs-node
19
1
Fork 20
Code Issues 93 Pull Requests 10 Actions Releases Activity

logger: Add journald support #971

Merged
fyrchik merged 1 commits from dstepanov-yadro/frostfs-node:feat/zapjournald into master 2024-02-12 06:17:24 +00:00
Conversation 0 Commits 1 Files Changed 11
dstepanov-yadro commented 2024-02-08 14:07:27 +00:00
Collaborator

Relates #736

Now it is possible to specify journald destination for logger.

The same approach as c334adeb6d/cmd/s3-gw/app_settings.go

Now journalctl uses zap's level:
image

Signed-off-by: Dmitrii Stepanov d.stepanov@yadro.com

Relates #736 Now it is possible to specify `journald` destination for logger. The same approach as https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/commit/c334adeb6da0bf6fa889b1bf8bb370ccc80f2b0e/cmd/s3-gw/app_settings.go Now `journalctl` uses zap's level: ![image](/attachments/88551b9c-1073-4a1e-bbe5-41e99e7e04a8) Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
image.png
426 KiB
dstepanov-yadro added 1 commit 2024-02-08 14:07:30 +00:00
DCO action / DCO (pull_request) Successful in 1m14s Details
Vulncheck / Vulncheck (pull_request) Successful in 3m28s Details
Tests and linters / Tests (1.21) (pull_request) Successful in 5m23s Details
Build / Build Components (1.21) (pull_request) Successful in 5m1s Details
Build / Build Components (1.20) (pull_request) Successful in 5m8s Details
Tests and linters / Staticcheck (pull_request) Successful in 5m19s Details
Tests and linters / Lint (pull_request) Successful in 5m47s Details
Tests and linters / Tests (1.20) (pull_request) Successful in 7m30s Details
Tests and linters / Tests with -race (pull_request) Successful in 7m22s Details
9d5c42b14a [#736] logger: Add journald support 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro requested review from storage-core-committers 2024-02-08 14:17:57 +00:00
dstepanov-yadro requested review from storage-core-developers 2024-02-08 14:17:58 +00:00
fyrchik reviewed 2024-02-08 17:35:07 +00:00
cmd/frostfs-node/config.go
@ -1012,1 +1014,4 @@
}
err = c.dynamicConfiguration.logger.SetDestination(c.LoggerCfg.destination)
if err != nil {
// not expected since validation should be performed before
fyrchik commented 2024-02-08 17:30:07 +00:00
Owner

Where is validation performed?
I see a comment in the previous if but it could be misleading too.

Where is validation performed? I see a comment in the previous `if` but it could be misleading too.
fyrchik commented 2024-02-08 17:34:56 +00:00
Owner

Also, do we change this on SIGHUP? Not saying that we need to (it could be even harmful), just to know

Also, do we change this on SIGHUP? Not saying that we need to (it could be even harmful), just to know
dstepanov-yadro commented 2024-02-09 07:00:13 +00:00
Poster
Collaborator

Where is validation performed?

Here: cmd/frostfs-node/validate.go

do we change this on SIGHUP

No.

> Where is validation performed? Here: `cmd/frostfs-node/validate.go` > do we change this on SIGHUP No.
fyrchik marked this conversation as resolved
pkg/util/logger/logger.go
@ -38,2 +43,4 @@
}
const (
DestinationUndefined = ""
fyrchik commented 2024-02-08 17:33:20 +00:00
Owner

We also have Loki which doesn't use this field. What about unifying the approach? (destination: loki)

We also have `Loki` which doesn't use this field. What about unifying the approach? (`destination: loki`)
dstepanov-yadro commented 2024-02-09 07:03:16 +00:00
Poster
Collaborator

loki works with both of journald and stdout, it is not a destination.

`loki` works with both of `journald` and `stdout`, it is not a destination.
fyrchik commented 2024-02-09 07:27:02 +00:00
Owner

Journald core can work with stdout too (it does by default I think)

Journald core can work with stdout too (it does by default I think)
dstepanov-yadro commented 2024-02-09 08:04:49 +00:00
Poster
Collaborator

So then destination possible values will be stdout, journald, stdout+loki, journald+loki? Looks ... strange.

So then `destination` possible values will be `stdout`, `journald`, `stdout+loki`, `journald+loki`? Looks ... strange.
fyrchik approved these changes 2024-02-09 14:15:55 +00:00
acid-ant approved these changes 2024-02-11 06:36:32 +00:00
fyrchik merged commit 962e5a9c19 into master 2024-02-12 06:17:24 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
acid-ant
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
badger

Badger DB related issues   
frostfs-adm
   
frostfs-cli
   
frostfs-ir
   
frostfs-lens
   
frostfs-node
   
good first issue

Good for newcomers   
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#971
There is no content yet.
Delete Branch "dstepanov-yadro/frostfs-node:feat/zapjournald"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?