Bump go version to 1.21 #972

New issue

Closed

opened 2024-02-08 15:40:30 +00:00 by fyrchik · 3 comments

fyrchik commented

2024-02-08 15:40:30 +00:00

Owner

This task is an aggregator of changes and gopatches:

min/max
clear
improvements in generic type inference (there was a place in api-go with a kludge)
adopt slices package
adopt maps package
context.WithDeadlineCause could improve error reporting in logs and frostfs-cli
crypto/elliptic is deprecated, see if we are affected (frostfs-crypto)
multipathTCP for multinet library
sync.OnceFunc, sync.OnceValue, sync.OnceValues

This task is an aggregator of changes and gopatches: - [x] min/max - [ ] clear - [ ] improvements in generic type inference (there was a place in api-go with a kludge) - [x] adopt slices package - [ ] adopt maps package - [ ] context.WithDeadlineCause could improve error reporting in logs and frostfs-cli - [ ] crypto/elliptic is deprecated, see if we are affected (frostfs-crypto) - [ ] multipathTCP for multinet library - [ ] sync.OnceFunc, sync.OnceValue, sync.OnceValues

👍 1

fyrchik added the

frostfs-node

label 2024-02-08 15:40:41 +00:00

fyrchik commented

2024-02-08 15:41:05 +00:00

Author

Owner

gopatch for min/max:

@@
var a, b expression
@@
-if a < b {
-	return a
-}
-return b
+return min(a, b)

@@
var a, b expression
@@
-if b > a {
-	return a
-}
-return b
+return min(a, b)

@@
var a, b expression
@@
-if a > b {
-	return a
-}
-return b
+return max(a, b)

@@
var a, b expression
@@
-if b < a {
-	return a
-}
-return b
+return max(a, b)

@@
var a, b expression
@@
-if a <= b {
-	return a
-}
-return b
+return min(a, b)

@@
var a, b expression
@@
-if b >= a {
-	return a
-}
-return b
+return min(a, b)

@@
var a, b expression
@@
-if a >= b {
-	return a
-}
-return b
+return max(a, b)

@@
var a, b expression
@@
-if b <= a {
-	return a
-}
-return b
+return max(a, b)


@@
var x, a, b expression
@@
-if a < b {
-	a = b
-}
+a = max(a, b)


@@
var x, a, b expression
@@
-if b > a {
-	a = b
-}
+a = max(a, b)


@@
var x, a, b expression
@@
-if a > b {
-	a = b
-}
+a = min(a, b)


@@
var x, a, b expression
@@
-if b < a {
-	a = b
-}
+a = min(a, b)


@@
var x, a, b expression
@@
-if a <= b {
-	a = b
-}
+a = max(a, b)


@@
var x, a, b expression
@@
-if b >= a {
-	a = b
-}
+a = max(a, b)


@@
var x, a, b expression
@@
-if a >= b {
-	a = b
-}
+a = min(a, b)


@@
var x, a, b expression
@@
-if b <= a {
-	a = b
-}
+a = min(a, b)

gopatch for min/max: ``` @@ var a, b expression @@ -if a < b { - return a -} -return b +return min(a, b) @@ var a, b expression @@ -if b > a { - return a -} -return b +return min(a, b) @@ var a, b expression @@ -if a > b { - return a -} -return b +return max(a, b) @@ var a, b expression @@ -if b < a { - return a -} -return b +return max(a, b) @@ var a, b expression @@ -if a <= b { - return a -} -return b +return min(a, b) @@ var a, b expression @@ -if b >= a { - return a -} -return b +return min(a, b) @@ var a, b expression @@ -if a >= b { - return a -} -return b +return max(a, b) @@ var a, b expression @@ -if b <= a { - return a -} -return b +return max(a, b) @@ var x, a, b expression @@ -if a < b { - a = b -} +a = max(a, b) @@ var x, a, b expression @@ -if b > a { - a = b -} +a = max(a, b) @@ var x, a, b expression @@ -if a > b { - a = b -} +a = min(a, b) @@ var x, a, b expression @@ -if b < a { - a = b -} +a = min(a, b) @@ var x, a, b expression @@ -if a <= b { - a = b -} +a = max(a, b) @@ var x, a, b expression @@ -if b >= a { - a = b -} +a = max(a, b) @@ var x, a, b expression @@ -if a >= b { - a = b -} +a = min(a, b) @@ var x, a, b expression @@ -if b <= a { - a = b -} +a = min(a, b) ```

fyrchik added

and removed

frostfs-node

labels 2024-02-08 15:58:17 +00:00

fyrchik commented

2024-02-08 16:27:00 +00:00

Author

Owner

Can be tricky, though

-       if d < 0 {
-               d = 0
-       }
+       d = max(d, 0)

Here the first zero is "lower boundary" and the second one it "the default value", it feels wrong to write max here.

Can be tricky, though ``` - if d < 0 { - d = 0 - } + d = max(d, 0) ``` Here the first zero is "lower boundary" and the second one it "the default value", it feels wrong to write `max` here.

fyrchik referenced this issue

2024-02-14 07:05:39 +00:00

Update go to 1.21 #985