Reduce waiting time on db drop during rebuild #983

New issue

Closed

opened 2024-02-14 06:26:18 +00:00 by fyrchik · 1 comment

fyrchik commented

2024-02-14 06:26:18 +00:00

Owner

Currently we wait for 10 seconds in dropDB() https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/pkg/local_object_storage/blobstor/blobovniczatree/rebuild.go#L222

This is needed because of the race condition:

Read storageID from the metabase
Move object to a new location and remove it from the old one
Read object by storageID from the blobovnicza.

We need to either allow setting this as a parameter or optimize via other means.

Currently we wait for 10 seconds in dropDB() https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/pkg/local_object_storage/blobstor/blobovniczatree/rebuild.go#L222 This is needed because of the race condition: 1. Read `storageID` from the metabase 2. Move object to a new location and remove it from the old one 3. Read object by `storageID` from the blobovnicza. We need to either allow setting this as a parameter or optimize via other means.

fyrchik added the

frostfs-node

perfomance

labels 2024-02-14 06:26:18 +00:00

fyrchik changed title from ~~Optimize rebuild~~ to Reduce waiting time on db drop during rebuild

2024-02-14 06:26:31 +00:00

fyrchik added the

good first issue

label 2024-02-14 06:30:11 +00:00

fyrchik added this to the vNext milestone 2024-02-14 08:40:07 +00:00

fyrchik removed the

good first issue

label 2024-02-14 08:40:13 +00:00

dstepanov-yadro self-assigned this 2024-03-01 10:18:46 +00:00

dstepanov-yadro referenced this issue

2024-03-04 15:13:09 +00:00

Allow to specify wait before drop time for blobovnicza #1022

fyrchik referenced this issue from a commit

2024-03-05 07:25:22 +00:00

[#983] blobstor: Allow to specify wait before drop time

dstepanov-yadro commented

2024-03-05 07:38:33 +00:00

Member

Added rebuild_drop_timeout parameter. See https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/docs/storage-node-configuration.md#blobovnicza-type-options

Added `rebuild_drop_timeout` parameter. See https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/docs/storage-node-configuration.md#blobovnicza-type-options

dstepanov-yadro closed this issue

2024-03-05 07:38:33 +00:00

fyrchik modified the milestone from vNext to v0.39.0

2024-05-02 07:37:30 +00:00