TrueCloudLab/frostfs-node
21
1
Fork 27
Code Issues 104 Pull requests 4 Projects Releases 2 Activity Actions

Makefile: fix target locode-download #1056

Merged
fyrchik merged 1 commit from elebedeva/frostfs-node:fix/locode-download into master 2024-03-28 19:57:46 +00:00
Conversation 1 Commits 1 Files changed 1 +3 -2
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 8690db697c - Show all commits

5
Makefile
View file

@ -265,8 +265,9 @@ debclean:
# Download locode database # Download locode database
locode-download: locode-download:
@wget -q -O ./.cache/locode_db.gz 'https://git.frostfs.info/TrueCloudLab/frostfs-locode-db/releases/download/${LOCODE_DB_VERSION}/locode_db.gz' mkdir -p $(TMP_DIR)
fyrchik commented 2024-03-26 11:49:44 +00:00
Outdated
Review
Copy link

mkdir has -p option which serves this purpose (ignore EEXIST), among others.
Also, while we are here: it seems that .cache is actually $(TMP_DIR) -- can we use it (see other targets, should be similar to this one).

`mkdir` has `-p` option which serves this purpose (ignore EEXIST), among others. Also, while we are here: it seems that `.cache` is actually `$(TMP_DIR)` -- can we use it (see other targets, should be similar to this one).
elebedeva commented 2024-03-28 12:09:10 +00:00
Outdated
Review
Copy link

Replaced condition with mkdir -p and .cache with $(TMP_DIR).

Should I replace .cache with $(TMP_DIR) in other targets as well?

Replaced condition with ```mkdir -p``` and ```.cache``` with ```$(TMP_DIR)```. Should I replace ```.cache``` with ```$(TMP_DIR)``` in other targets as well?
gzip -dfk ./.cache/locode_db.gz @wget -q -O ./$(TMP_DIR)/locode_db.gz 'https://git.frostfs.info/TrueCloudLab/frostfs-locode-db/releases/download/${LOCODE_DB_VERSION}/locode_db.gz'
gzip -dfk ./$(TMP_DIR)/locode_db.gz
# Start dev environment # Start dev environment
env-up: all env-up: all