TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 93 Pull requests 4 Projects Releases 1 Activity Actions

netmap: Do not iterate over external addresses in Node #1057

Merged
fyrchik merged 1 commit from fyrchik/frostfs-node:fix-external-addr into master 2024-03-29 20:46:25 +00:00
Conversation 0 Commits 1 Files changed 1 -5
1 changed files with 0 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 1ecb251b9e - Show all commits

5
pkg/core/netmap/nodes.go
View file

@ -18,11 +18,6 @@ func (x Node) PublicKey() []byte {
// and passes them into f. Handler MUST NOT be nil.
func (x Node) IterateAddresses(f func(string) bool) {
(netmap.NodeInfo)(x).IterateNetworkEndpoints(f)
for _, addr := range (netmap.NodeInfo)(x).ExternalAddresses() {
aarifullin commented 2024-03-28 10:27:50 +00:00
Review
Copy link

Could you explain, please, why?

Could you explain, please, why?
fyrchik commented 2024-03-28 14:39:00 +00:00
Review
Copy link

This wrapper still contains ExternalAddresses field, which is used in places where we need them.
In IterateAddresses only internal are expected.
Though, this line was here from the initial implementation

This wrapper still contains `ExternalAddresses` field, which is used in places where we need them. In `IterateAddresses` only internal are expected. Though, this line was here from the initial implementation
if f(addr) {
return
}
}
}
// NumberOfAddresses returns number of announced network addresses.