TrueCloudLab/frostfs-node
21
1
Fork 27
Code Issues 107 Pull requests 3 Projects Releases 1 Activity Actions

shard: Update metric mode_info on Init #1174

Merged
fyrchik merged 1 commit from acid-ant/frostfs-node:bugfix/upd-mode-metric-init into master 2024-06-13 08:33:06 +00:00
Conversation 1 Commits 1 Files changed 1 +1
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
pkg/local_object_storage/shard/shard.go
View file

@ -484,6 +484,7 @@ func (s *Shard) updateMetrics(ctx context.Context) {
s.setContainerObjectsCount(contID.EncodeToString(), logical, count.Logic) s.setContainerObjectsCount(contID.EncodeToString(), logical, count.Logic)
s.setContainerObjectsCount(contID.EncodeToString(), user, count.User) s.setContainerObjectsCount(contID.EncodeToString(), user, count.User)
} }
s.cfg.metricsWriter.SetMode(s.info.Mode)
fyrchik marked this conversation as resolved
fyrchik commented 2024-06-13 07:52:49 +00:00
Review
Copy link

All other methods check whether s.cfg.metricsWriter != nil, I suggest adding the check here too.

All other methods check whether `s.cfg.metricsWriter != nil`, I suggest adding the check here too.
acid-ant commented 2024-06-13 08:00:19 +00:00
Review
Copy link

It's done at the beginning of the method.

It's done at the beginning of the method.
} }
// incObjectCounter increment both physical and logical object // incObjectCounter increment both physical and logical object