TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 101 Pull requests 5 Projects Releases 1 Activity Actions

Check if metabase file exists before read shard ID #1178

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-node:fix/update_shard_id into master 2024-06-17 07:44:57 +00:00
Conversation 0 Commits 1 Files changed 1 +5
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
pkg/local_object_storage/metabase/shard_id.go
View file

@ -4,6 +4,7 @@ import (
"bytes" "bytes"
"errors" "errors"
"fmt" "fmt"
"os"
"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/internal/metaerr" "git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/internal/metaerr"
metamode "git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/shard/mode" metamode "git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/shard/mode"
@ -25,6 +26,10 @@ func (db *DB) GetShardID(mode metamode.Mode) ([]byte, error) {
defer db.modeMtx.Unlock() defer db.modeMtx.Unlock()
db.mode = mode db.mode = mode
if _, err := os.Stat(db.info.Path); errors.Is(err, os.ErrNotExist) {
fyrchik commented 2024-06-17 07:24:44 +00:00
Review
Copy link

The error happens on shard ID update, but we change ReadShardID, which should function in RO mode. Why so?

The error happens on shard ID update, but we change `ReadShardID`, which should function in RO mode. Why so?
dstepanov-yadro commented 2024-06-17 07:28:41 +00:00
Review
Copy link

See next line: db.openDB(mode) creates DB file if DB doesn't exist.

See next line: `db.openDB(mode)` creates DB file if DB doesn't exist.
return nil, nil
}
if err := db.openDB(mode); err != nil { if err := db.openDB(mode); err != nil {
return nil, fmt.Errorf("failed to open metabase: %w", err) return nil, fmt.Errorf("failed to open metabase: %w", err)
} }