node/ir: Handle double SIGHUP correctly #1197
2 changed files with 60 additions and 22 deletions
|
@ -45,18 +45,41 @@ func reloadConfig() error {
|
||||||
|
|
||||||
func watchForSignal(cancel func()) {
|
func watchForSignal(cancel func()) {
|
||||||
ch := make(chan os.Signal, 1)
|
ch := make(chan os.Signal, 1)
|
||||||
signal.Notify(ch, syscall.SIGHUP, syscall.SIGINT, syscall.SIGTERM)
|
signal.Notify(ch, syscall.SIGINT, syscall.SIGTERM)
|
||||||
|
|
||||||
|
sighupCh := make(chan os.Signal, 1)
|
||||||
|
signal.Notify(sighupCh, syscall.SIGHUP)
|
||||||
|
|
||||||
for {
|
for {
|
||||||
select {
|
select {
|
||||||
case err := <-intErr:
|
// signals causing application to shut down should have priority over
|
||||||
|
// reconfiguration signal
|
||||||
|
case <-ch:
|
||||||
|
log.Info(logs.FrostFSNodeTerminationSignalHasBeenReceivedStopping)
|
||||||
|
cancel()
|
||||||
|
shutdown()
|
||||||
|
log.Info(logs.FrostFSNodeTerminationSignalProcessingIsComplete)
|
||||||
|
return
|
||||||
|
case err := <-intErr: // internal application error
|
||||||
log.Info(logs.FrostFSIRInternalError, zap.String("msg", err.Error()))
|
log.Info(logs.FrostFSIRInternalError, zap.String("msg", err.Error()))
|
||||||
cancel()
|
cancel()
|
||||||
shutdown()
|
shutdown()
|
||||||
return
|
return
|
||||||
case sig := <-ch:
|
default:
|
||||||
switch sig {
|
// block until any signal is receieved
|
||||||
case syscall.SIGHUP:
|
select {
|
||||||
|
case <-ch:
|
||||||
|
log.Info(logs.FrostFSNodeTerminationSignalHasBeenReceivedStopping)
|
||||||
|
cancel()
|
||||||
|
shutdown()
|
||||||
|
log.Info(logs.FrostFSNodeTerminationSignalProcessingIsComplete)
|
||||||
|
return
|
||||||
|
case err := <-intErr: // internal application error
|
||||||
|
log.Info(logs.FrostFSIRInternalError, zap.String("msg", err.Error()))
|
||||||
|
cancel()
|
||||||
|
shutdown()
|
||||||
|
return
|
||||||
|
case <-sighupCh:
|
||||||
log.Info(logs.FrostFSNodeSIGHUPHasBeenReceivedRereadingConfiguration)
|
log.Info(logs.FrostFSNodeSIGHUPHasBeenReceivedRereadingConfiguration)
|
||||||
err := reloadConfig()
|
err := reloadConfig()
|
||||||
if err != nil {
|
if err != nil {
|
||||||
|
@ -70,12 +93,6 @@ func watchForSignal(cancel func()) {
|
||||||
log.Error(logs.FrostFSNodeConfigurationReading, zap.Error(err))
|
log.Error(logs.FrostFSNodeConfigurationReading, zap.Error(err))
|
||||||
}
|
}
|
||||||
log.Info(logs.FrostFSNodeConfigurationHasBeenReloadedSuccessfully)
|
log.Info(logs.FrostFSNodeConfigurationHasBeenReloadedSuccessfully)
|
||||||
case syscall.SIGTERM, syscall.SIGINT:
|
|
||||||
log.Info(logs.FrostFSNodeTerminationSignalHasBeenReceivedStopping)
|
|
||||||
cancel()
|
|
||||||
shutdown()
|
|
||||||
log.Info(logs.FrostFSNodeTerminationSignalProcessingIsComplete)
|
|
||||||
return
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
|
@ -1224,22 +1224,22 @@ type dCmp struct {
|
||||||
|
|
||||||
func (c *cfg) signalWatcher(ctx context.Context) {
|
func (c *cfg) signalWatcher(ctx context.Context) {
|
||||||
ch := make(chan os.Signal, 1)
|
ch := make(chan os.Signal, 1)
|
||||||
signal.Notify(ch, syscall.SIGHUP, syscall.SIGINT, syscall.SIGTERM)
|
signal.Notify(ch, syscall.SIGINT, syscall.SIGTERM)
|
||||||
|
|
||||||
|
sighupCh := make(chan os.Signal, 1)
|
||||||
|
signal.Notify(sighupCh, syscall.SIGHUP)
|
||||||
|
|
||||||
for {
|
for {
|
||||||
select {
|
select {
|
||||||
case sig := <-ch:
|
// signals causing application to shut down should have priority over
|
||||||
switch sig {
|
// reconfiguration signal
|
||||||
case syscall.SIGHUP:
|
case <-ch:
|
||||||
c.reloadConfig(ctx)
|
c.log.Info(logs.FrostFSNodeTerminationSignalHasBeenReceivedStopping)
|
||||||
case syscall.SIGTERM, syscall.SIGINT:
|
|
||||||
c.log.Info(logs.FrostFSNodeTerminationSignalHasBeenReceivedStopping)
|
|
||||||
|
|
||||||
c.shutdown()
|
c.shutdown()
|
||||||
|
|
||||||
c.log.Info(logs.FrostFSNodeTerminationSignalProcessingIsComplete)
|
c.log.Info(logs.FrostFSNodeTerminationSignalProcessingIsComplete)
|
||||||
return
|
return
|
||||||
}
|
|
||||||
case err := <-c.internalErr: // internal application error
|
case err := <-c.internalErr: // internal application error
|
||||||
c.log.Warn(logs.FrostFSNodeInternalApplicationError,
|
c.log.Warn(logs.FrostFSNodeInternalApplicationError,
|
||||||
zap.String("message", err.Error()))
|
zap.String("message", err.Error()))
|
||||||
|
@ -1248,6 +1248,27 @@ func (c *cfg) signalWatcher(ctx context.Context) {
|
||||||
|
|
||||||
c.log.Info(logs.FrostFSNodeInternalErrorProcessingIsComplete)
|
c.log.Info(logs.FrostFSNodeInternalErrorProcessingIsComplete)
|
||||||
return
|
return
|
||||||
|
default:
|
||||||
|
// block until any signal is receieved
|
||||||
|
select {
|
||||||
|
case <-sighupCh:
|
||||||
|
c.reloadConfig(ctx)
|
||||||
|
case <-ch:
|
||||||
|
c.log.Info(logs.FrostFSNodeTerminationSignalHasBeenReceivedStopping)
|
||||||
|
|
||||||
|
c.shutdown()
|
||||||
|
|
||||||
|
c.log.Info(logs.FrostFSNodeTerminationSignalProcessingIsComplete)
|
||||||
|
return
|
||||||
|
case err := <-c.internalErr: // internal application error
|
||||||
|
c.log.Warn(logs.FrostFSNodeInternalApplicationError,
|
||||||
|
zap.String("message", err.Error()))
|
||||||
|
|
||||||
|
c.shutdown()
|
||||||
|
|
||||||
|
c.log.Info(logs.FrostFSNodeInternalErrorProcessingIsComplete)
|
||||||
|
return
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue