TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 104 Pull requests 13 Projects Releases 2 Activity Actions

refactoring: make unused linter stricker #1388

Merged
dstepanov-yadro merged 15 commits from dstepanov-yadro/frostfs-node:refactoring/drop_unused into master 2024-09-25 08:55:39 +00:00
Conversation 2 Commits 15 Files changed 28 +4
2 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 62c8e6554c - Show all commits

2
cmd/frostfs-lens/internal/schema/common/raw.go
View file

@ -7,6 +7,8 @@ import (
) )
type RawEntry struct { type RawEntry struct {
// key and value used for record dump.
dstepanov-yadro commented 2024-09-23 06:25:32 +00:00
Outdated
Review
Copy link

@a-savchuk please review

@a-savchuk please review
// nolint:unused
key, value []byte key, value []byte
a-savchuk marked this conversation as resolved Outdated
a-savchuk commented 2024-09-24 12:52:55 +00:00
Outdated
Review
Copy link

For a raw entry, as for any entry, we wanna be able to see its dump (see DetailedString method). Both fields key and value are intended to be shown in a dump view. Could we ignore the lint warning here? or should we do something trickier like this

func (r *RawEntry) DetailedString() string {
	_ = r.value // both value and key need to be used in dump 
	return spew.Sdump(r)
}

and add an additional comment to describe that decision?

For a raw entry, as for any entry, we wanna be able to see its dump (see `DetailedString` method). Both fields `key` and `value` are intended to be shown in a dump view. Could we ignore the lint warning here? or should we do something trickier like this ```go func (r *RawEntry) DetailedString() string { _ = r.value // both value and key need to be used in dump return spew.Sdump(r) } ``` and add an additional comment to describe that decision?
dstepanov-yadro commented 2024-09-24 13:00:59 +00:00
Review
Copy link

fixed

fixed
} }

2
cmd/frostfs-lens/internal/schema/writecache/types.go
View file

@ -16,6 +16,8 @@ type (
DefaultRecord struct { DefaultRecord struct {
addr oid.Address addr oid.Address
// data used for record dump.
// nolint:unused
data []byte data []byte
a-savchuk marked this conversation as resolved Outdated
a-savchuk commented 2024-09-24 12:54:33 +00:00
Outdated
Review
Copy link

Same comment as the one for RawEntry. We should keep that field for DetailedString method

Same comment as the one for `RawEntry`. We should keep that field for `DetailedString` method
dstepanov-yadro commented 2024-09-24 13:01:13 +00:00
Review
Copy link

fixed

fixed
} }
) )