.golangci.yml

@@ -38,6 +38,10 @@ linters-settings:
     alias:
       pkg: git.frostfs.info/TrueCloudLab/frostfs-sdk-go/object
       alias: objectSDK
+  unused:
+    field-writes-are-uses: false
+    exported-fields-are-used: false
+    local-variables-are-used: false
   custom:
     truecloudlab-linters:
       path: bin/linters/external_linters.so

cmd/frostfs-cli/internal/client/client.go

@@ -565,13 +565,6 @@ type HeadObjectPrm struct {
 	commonObjectPrm
 	objectAddressPrm
 	rawPrm
-
-	mainOnly bool
-}
-
-// SetMainOnlyFlag sets flag to get only main fields of an object header in terms of FrostFS API.
-func (x *HeadObjectPrm) SetMainOnlyFlag(v bool) {
-	x.mainOnly = v
 }
 
 // HeadObjectRes groups the resulting values of HeadObject operation.

cmd/frostfs-cli/modules/object/head.go

@@ -38,7 +38,6 @@ func initObjectHeadCmd() {
 	_ = objectHeadCmd.MarkFlagRequired(commonflags.OIDFlag)
 
 	flags.String(fileFlag, "", "File to write header to. Default: stdout.")
-	flags.Bool("main-only", false, "Return only main fields")
 	flags.Bool(commonflags.JSON, false, "Marshal output in JSON")
 	flags.Bool("proto", false, "Marshal output in Protobuf")
 	flags.Bool(rawFlag, false, rawFlagDesc)
@@ -49,7 +48,6 @@ func getObjectHeader(cmd *cobra.Command, _ []string) {
 	var obj oid.ID
 
 	objAddr := readObjectAddress(cmd, &cnr, &obj)
-	mainOnly, _ := cmd.Flags().GetBool("main-only")
 	pk := key.GetOrGenerate(cmd)
 
 	cli := internalclient.GetSDKClientByFlag(cmd, pk, commonflags.RPC)
@@ -62,7 +60,6 @@ func getObjectHeader(cmd *cobra.Command, _ []string) {
 	raw, _ := cmd.Flags().GetBool(rawFlag)
 	prm.SetRawFlag(raw)
 	prm.SetAddress(objAddr)
-	prm.SetMainOnlyFlag(mainOnly)
 
 	res, err := internalclient.HeadObject(cmd.Context(), prm)
 	if err != nil {

cmd/frostfs-lens/internal/schema/common/raw.go

@@ -7,6 +7,8 @@ import (
 )
 
 type RawEntry struct {
+	// key and value used for record dump.
+	// nolint:unused
 	key, value []byte
 }
 

cmd/frostfs-lens/internal/schema/writecache/types.go

@@ -16,6 +16,8 @@ type (
 
 	DefaultRecord struct {
 		addr oid.Address
+		// data used for record dump.
+		// nolint:unused
 		data []byte
 	}
 )

cmd/frostfs-node/config.go

@@ -602,7 +602,6 @@ type cfgNetmap struct {
 
 	needBootstrap       bool
 	reBoostrapTurnedOff *atomic.Bool // managed by control service in runtime
-	startEpoch          uint64       // epoch number when application is started
 }
 
 type cfgNodeInfo struct {
@@ -1082,7 +1081,6 @@ func initAccessPolicyEngine(_ context.Context, c *cfg) {
 		localOverrideDB = chainbase.NewInmemoryLocalOverrideDatabase()
 	} else {
 		localOverrideDB = chainbase.NewBoltLocalOverrideDatabase(
-			chainbase.WithLogger(c.log),
 			chainbase.WithPath(nodeconfig.PersistentPolicyRules(c.appCfg).Path()),
 			chainbase.WithPerm(nodeconfig.PersistentPolicyRules(c.appCfg).Perm()),
 			chainbase.WithNoSync(nodeconfig.PersistentPolicyRules(c.appCfg).NoSync()),

cmd/frostfs-node/container.go

@@ -128,9 +128,6 @@ func configureEACLAndContainerSources(c *cfg, client *cntClient.Client, cnrSrc c
 		cnrRdr.lister = client
 		cnrRdr.eacl = c.cfgObject.eaclSource
 		cnrRdr.src = c.cfgObject.cnrSource
-
-		cnrWrt.cacheEnabled = true
-		cnrWrt.eacls = cachedEACLStorage
 	}
 
 	return cnrRdr, cnrWrt
@@ -247,9 +244,6 @@ func (x *morphContainerReader) ContainersOf(id *user.ID) ([]cid.ID, error) {
 
 type morphContainerWriter struct {
 	neoClient *cntClient.Client
-
-	cacheEnabled bool
-	eacls        ttlEACLStorage
 }
 
 func (m morphContainerWriter) Put(cnr containerCore.Container) (*cid.ID, error) {

cmd/frostfs-node/netmap.go

@@ -259,7 +259,6 @@ func initNetmapState(c *cfg) {
 	}
 
 	c.cfgNetmap.state.setCurrentEpoch(epoch)
-	c.cfgNetmap.startEpoch = epoch
 	c.setContractNodeInfo(ni)
 }
 

cmd/frostfs-node/object.go

@@ -473,7 +473,6 @@ func createACLServiceV2(c *cfg, apeSvc *objectAPE.Service, irFetcher *cachedIRFe
 
 func createAPEService(c *cfg, splitSvc *objectService.TransportSplitter) *objectAPE.Service {
 	return objectAPE.NewService(
-		c.log,
 		objectAPE.NewChecker(
 			c.cfgObject.cfgAccessPolicyEngine.accessPolicyEngine.LocalStorage(),
 			c.cfgObject.cfgAccessPolicyEngine.accessPolicyEngine.MorphRuleChainStorage(),

cmd/frostfs-node/policy_engine.go

@@ -21,7 +21,9 @@ type accessPolicyEngine struct {
 var _ engine.MorphRuleChainStorageReader = (*morphAPEChainCache)(nil)
 
 type morphAPEChainCacheKey struct {
-	name   chain.Name
+	// nolint:unused
+	name chain.Name
+	// nolint:unused
 	target engine.Target
 }
 

internal/metrics/innerring.go

@@ -17,7 +17,8 @@ type InnerRingServiceMetrics struct {
 	eventDuration     *prometheus.HistogramVec
 	morphCacheMetrics *morphCacheMetrics
 	logMetrics        logger.LogMetrics
-	appInfo           *ApplicationInfo
+	// nolint: unused
+	appInfo *ApplicationInfo
 }
 
 // NewInnerRingMetrics returns new instance of metrics collectors for inner ring.

internal/metrics/node.go

@@ -25,7 +25,8 @@ type NodeMetrics struct {
 	morphClient   *morphClientMetrics
 	morphCache    *morphCacheMetrics
 	log           logger.LogMetrics
-	appInfo       *ApplicationInfo
+	// nolint: unused
+	appInfo *ApplicationInfo
 }
 
 func NewNodeMetrics() *NodeMetrics {

pkg/ape/chainbase/option.go

@@ -5,9 +5,7 @@ import (
 	"os"
 	"time"
 
-	"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/util/logger"
 	"go.etcd.io/bbolt"
-	"go.uber.org/zap"
 )
 
 type Option func(*cfg)
@@ -18,7 +16,6 @@ type cfg struct {
 	noSync        bool
 	maxBatchDelay time.Duration
 	maxBatchSize  int
-	log           *logger.Logger
 }
 
 func defaultCfg() *cfg {
@@ -26,7 +23,6 @@ func defaultCfg() *cfg {
 		perm:          os.ModePerm,
 		maxBatchDelay: bbolt.DefaultMaxBatchDelay,
 		maxBatchSize:  bbolt.DefaultMaxBatchSize,
-		log:           &logger.Logger{Logger: zap.L()},
 	}
 }
 
@@ -59,9 +55,3 @@ func WithMaxBatchSize(maxBatchSize int) Option {
 		c.maxBatchSize = maxBatchSize
 	}
 }
-
-func WithLogger(l *logger.Logger) Option {
-	return func(c *cfg) {
-		c.log = l
-	}
-}

pkg/innerring/initialization.go

@@ -163,7 +163,6 @@ func (s *Server) createAlphaSync(cfg *viper.Viper, frostfsCli *frostfsClient.Cli
 			Log:           s.log,
 			Metrics:       s.irMetrics,
 			FrostFSClient: frostfsCli,
-			NetmapClient:  s.netmapClient,
 			AlphabetState: s,
 			EpochState:    s,
 			Voter:         s,

pkg/innerring/innerring.go

@@ -103,6 +103,8 @@ type (
 		// to the application.
 		runners []func(chan<- error) error
 
+		// cmode used for upgrade scenario.
+		// nolint:unused
 		cmode *atomic.Bool
 	}
 

pkg/innerring/processors/governance/handlers_test.go

@@ -8,7 +8,6 @@ import (
 
 	"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/morph/client"
 	frostfscontract "git.frostfs.info/TrueCloudLab/frostfs-node/pkg/morph/client/frostfs"
-	nmClient "git.frostfs.info/TrueCloudLab/frostfs-node/pkg/morph/client/netmap"
 	"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/morph/event/rolemanagement"
 	"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/util/logger/test"
 	"github.com/nspcc-dev/neo-go/pkg/core/native/noderoles"
@@ -38,7 +37,6 @@ func TestHandleAlphabetSyncEvent(t *testing.T) {
 		alphabetKeys: testKeys.mainnetKeys,
 	}
 	f := &testFrostFSClient{}
-	nm := &testNetmapClient{}
 
 	proc, err := New(
 		&Params{
@@ -50,7 +48,6 @@ func TestHandleAlphabetSyncEvent(t *testing.T) {
 			MorphClient:   m,
 			MainnetClient: mn,
 			FrostFSClient: f,
-			NetmapClient:  nm,
 		},
 	)
 
@@ -73,10 +70,6 @@ func TestHandleAlphabetSyncEvent(t *testing.T) {
 		},
 	}, v.votes, "invalid vote calls")
 
-	var irUpdateExp []nmClient.UpdateIRPrm
-
-	require.EqualValues(t, irUpdateExp, nm.updates, "invalid IR updates")
-
 	var expAlphabetUpdate client.UpdateAlphabetListPrm
 	expAlphabetUpdate.SetHash(ev.txHash)
 	expAlphabetUpdate.SetList(testKeys.newInnerRingExp)
@@ -119,7 +112,6 @@ func TestHandleAlphabetDesignateEvent(t *testing.T) {
 		alphabetKeys: testKeys.mainnetKeys,
 	}
 	f := &testFrostFSClient{}
-	nm := &testNetmapClient{}
 
 	proc, err := New(
 		&Params{
@@ -131,7 +123,6 @@ func TestHandleAlphabetDesignateEvent(t *testing.T) {
 			MorphClient:   m,
 			MainnetClient: mn,
 			FrostFSClient: f,
-			NetmapClient:  nm,
 		},
 	)
 
@@ -155,9 +146,6 @@ func TestHandleAlphabetDesignateEvent(t *testing.T) {
 		},
 	}, v.votes, "invalid vote calls")
 
-	var irUpdatesExp []nmClient.UpdateIRPrm
-	require.EqualValues(t, irUpdatesExp, nm.updates, "invalid IR updates")
-
 	var alpabetUpdExp client.UpdateAlphabetListPrm
 	alpabetUpdExp.SetList(testKeys.newInnerRingExp)
 	alpabetUpdExp.SetHash(ev.TxHash)
@@ -293,12 +281,3 @@ func (c *testFrostFSClient) AlphabetUpdate(p frostfscontract.AlphabetUpdatePrm)
 	c.updates = append(c.updates, p)
 	return nil
 }
-
-type testNetmapClient struct {
-	updates []nmClient.UpdateIRPrm
-}
-
-func (c *testNetmapClient) UpdateInnerRing(p nmClient.UpdateIRPrm) error {
-	c.updates = append(c.updates, p)
-	return nil
-}

pkg/innerring/processors/governance/processor.go

@@ -79,7 +79,6 @@ type (
 		metrics       metrics.Register
 		pool          *ants.Pool
 		frostfsClient FrostFSClient
-		netmapClient  NetmapClient
 
 		alphabetState AlphabetState
 		epochState    EpochState
@@ -105,7 +104,6 @@ type (
 		MorphClient   MorphClient
 		MainnetClient MainnetClient
 		FrostFSClient FrostFSClient
-		NetmapClient  NetmapClient
 	}
 )
 
@@ -146,7 +144,6 @@ func New(p *Params) (*Processor, error) {
 		metrics:       metricsRegister,
 		pool:          pool,
 		frostfsClient: p.FrostFSClient,
-		netmapClient:  p.NetmapClient,
 		alphabetState: p.AlphabetState,
 		epochState:    p.EpochState,
 		voter:         p.Voter,

pkg/local_object_storage/blobstor/memstore/control.go

@@ -10,11 +10,11 @@ func (s *memstoreImpl) Open(mod mode.ComponentMode) error {
 	return nil
 }
 
-func (s *memstoreImpl) Init() error                              { return nil }
+func (s *memstoreImpl) Init() error                            { return nil }
-func (s *memstoreImpl) Close() error                             { return nil }
+func (s *memstoreImpl) Close() error                           { return nil }
-func (s *memstoreImpl) Type() string                             { return Type }
+func (s *memstoreImpl) Type() string                           { return Type }
-func (s *memstoreImpl) Path() string                             { return s.rootPath }
+func (s *memstoreImpl) Path() string                           { return s.rootPath }
-func (s *memstoreImpl) SetCompressor(cc *compression.Config)     { s.compression = cc }
+func (s *memstoreImpl) SetCompressor(cc *compression.Config)   { s.compression = cc }
-func (s *memstoreImpl) Compressor() *compression.Config          { return s.compression }
+func (s *memstoreImpl) Compressor() *compression.Config        { return s.compression }
-func (s *memstoreImpl) SetReportErrorFunc(f func(string, error)) { s.reportError = f }
+func (s *memstoreImpl) SetReportErrorFunc(func(string, error)) {}
-func (s *memstoreImpl) SetParentID(string)                       {}
+func (s *memstoreImpl) SetParentID(string)                     {}

pkg/local_object_storage/blobstor/memstore/memstore_test.go

@@ -8,7 +8,6 @@ import (
 	"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/blobstor/common"
 	"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/blobstor/internal/blobstortest"
 	"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/shard/mode"
-	"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/util/logger/test"
 	objectSDK "git.frostfs.info/TrueCloudLab/frostfs-sdk-go/object"
 	"github.com/stretchr/testify/require"
 )
@@ -16,7 +15,6 @@ import (
 func TestSimpleLifecycle(t *testing.T) {
 	s := New(
 		WithRootPath("memstore"),
-		WithLogger(test.NewLogger(t)),
 	)
 	defer func() { require.NoError(t, s.Close()) }()
 	require.NoError(t, s.Open(mode.ComponentReadWrite))

pkg/local_object_storage/blobstor/memstore/option.go

@@ -2,33 +2,20 @@ package memstore
 
 import (
 	"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/blobstor/compression"
-	"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/util/logger"
-	"go.uber.org/zap"
 )
 
 type cfg struct {
-	log         *logger.Logger
 	rootPath    string
 	readOnly    bool
 	compression *compression.Config
-	reportError func(string, error)
 }
 
 func defaultConfig() *cfg {
-	return &cfg{
+	return &cfg{}
-		log:         &logger.Logger{Logger: zap.L()},
-		reportError: func(string, error) {},
-	}
 }
 
 type Option func(*cfg)
 
-func WithLogger(l *logger.Logger) Option {
-	return func(c *cfg) {
-		c.log = l
-	}
-}
-
 func WithRootPath(p string) Option {
 	return func(c *cfg) {
 		c.rootPath = p

pkg/local_object_storage/engine/control.go

@@ -249,23 +249,9 @@ func (e *StorageEngine) ResumeExecution() error {
 }
 
 type ReConfiguration struct {
-	errorsThreshold uint32
-	shardPoolSize   uint32
-
 	shards map[string][]shard.Option // meta path -> shard opts
 }
 
-// SetErrorsThreshold sets a size amount of errors after which
-// shard is moved to read-only mode.
-func (rCfg *ReConfiguration) SetErrorsThreshold(errorsThreshold uint32) {
-	rCfg.errorsThreshold = errorsThreshold
-}
-
-// SetShardPoolSize sets a size of worker pool for each shard.
-func (rCfg *ReConfiguration) SetShardPoolSize(shardPoolSize uint32) {
-	rCfg.shardPoolSize = shardPoolSize
-}
-
 // AddShard adds a shard for the reconfiguration.
 // Shard identifier is calculated from paths used in blobstor.
 func (rCfg *ReConfiguration) AddShard(id string, opts []shard.Option) {

pkg/local_object_storage/metabase/delete.go

@@ -77,8 +77,6 @@ func (p *DeletePrm) SetAddresses(addrs ...oid.Address) {
 type referenceNumber struct {
 	all, cur int
 
-	addr oid.Address
-
 	obj *objectSDK.Object
 }
 
@@ -295,9 +293,8 @@ func (db *DB) delete(tx *bbolt.Tx, addr oid.Address, refCounter referenceCounter
 		nRef, ok := refCounter[k]
 		if !ok {
 			nRef = &referenceNumber{
-				all:  parentLength(tx, parAddr),
+				all: parentLength(tx, parAddr),
-				addr: parAddr,
+				obj: parent,
-				obj:  parent,
 			}
 
 			refCounter[k] = nRef

pkg/services/object/ape/service.go

@@ -12,7 +12,6 @@ import (
 	objectSvc "git.frostfs.info/TrueCloudLab/frostfs-node/pkg/services/object"
 	getsvc "git.frostfs.info/TrueCloudLab/frostfs-node/pkg/services/object/get"
 	"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/services/object/util"
-	"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/util/logger"
 	"git.frostfs.info/TrueCloudLab/frostfs-sdk-go/bearer"
 	cid "git.frostfs.info/TrueCloudLab/frostfs-sdk-go/container/id"
 	objectSDK "git.frostfs.info/TrueCloudLab/frostfs-sdk-go/object"
@@ -24,8 +23,6 @@ import (
 var errFailedToCastToRequestContext = errors.New("failed cast to RequestContext")
 
 type Service struct {
-	log *logger.Logger
-
 	apeChecker Checker
 
 	next objectSvc.ServiceServer
@@ -67,9 +64,8 @@ func NewStorageEngineHeaderProvider(e *engine.StorageEngine, s *getsvc.Service)
 	}
 }
 
-func NewService(log *logger.Logger, apeChecker Checker, next objectSvc.ServiceServer) *Service {
+func NewService(apeChecker Checker, next objectSvc.ServiceServer) *Service {
 	return &Service{
-		log:        log,
 		apeChecker: apeChecker,
 		next:       next,
 	}

pkg/services/object/get/assembleec.go

@@ -43,7 +43,7 @@ func (r *request) assembleEC(ctx context.Context) {
 	}
 
 	r.prm.common = r.prm.common.WithLocalOnly(false)
-	assembler := newAssemblerEC(r.address(), r.infoEC, r.ctxRange(), r, r.localStorage, r.containerSource, r.log, r.headOnly(), r.traverserGenerator, r.curProcEpoch)
+	assembler := newAssemblerEC(r.address(), r.infoEC, r.ctxRange(), r, r.localStorage, r.log, r.headOnly(), r.traverserGenerator, r.curProcEpoch)
 
 	r.log.Debug(logs.GetAssemblingECObject,
 		zap.Uint64("range_offset", r.ctxRange().GetOffset()),

pkg/services/object/get/assemblerec.go

@@ -34,7 +34,6 @@ type assemblerec struct {
 	rng                *objectSDK.Range
 	remoteStorage      ecRemoteStorage
 	localStorage       localStorage
-	cs                 container.Source
 	log                *logger.Logger
 	head               bool
 	traverserGenerator traverserGenerator
@@ -47,7 +46,6 @@ func newAssemblerEC(
 	rng *objectSDK.Range,
 	remoteStorage ecRemoteStorage,
 	localStorage localStorage,
-	cs container.Source,
 	log *logger.Logger,
 	head bool,
 	tg traverserGenerator,
@@ -59,7 +57,6 @@ func newAssemblerEC(
 		ecInfo:             ecInfo,
 		remoteStorage:      remoteStorage,
 		localStorage:       localStorage,
-		cs:                 cs,
 		log:                log,
 		head:               head,
 		traverserGenerator: tg,

pkg/services/object/put/prm.go

@@ -2,7 +2,6 @@ package putsvc
 
 import (
 	"context"
-	"crypto/ecdsa"
 
 	"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/core/client"
 	"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/services/object/util"
@@ -21,8 +20,6 @@ type PutInitPrm struct {
 	traverseOpts []placement.Option
 
 	relay func(context.Context, client.NodeInfo, client.MultiAddressClient) error
-
-	privateKey *ecdsa.PrivateKey
 }
 
 type PutChunkPrm struct {
@@ -68,11 +65,3 @@ func (p *PutChunkPrm) WithChunk(v []byte) *PutChunkPrm {
 
 	return p
 }
-
-func (p *PutInitPrm) WithPrivateKey(v *ecdsa.PrivateKey) *PutInitPrm {
-	if p != nil {
-		p.privateKey = v
-	}
-
-	return p
-}

pkg/services/object/sign.go

@@ -10,8 +10,6 @@ import (
 )
 
 type SignService struct {
-	key *ecdsa.PrivateKey
-
 	sigSvc *util.SignService
 
 	svc ServiceServer
@@ -48,7 +46,6 @@ type getRangeStreamSigner struct {
 
 func NewSignService(key *ecdsa.PrivateKey, svc ServiceServer) *SignService {
 	return &SignService{
-		key:    key,
 		sigSvc: util.NewUnarySignService(key),
 		svc:    svc,
 	}

pkg/services/session/storage/temporary/storage.go

@@ -9,7 +9,9 @@ import (
 )
 
 type key struct {
+	// nolint:unused
 	tokenID string
+	// nolint:unused
 	ownerID string
 }