TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 101 Pull requests 5 Projects Releases 1 Activity Actions 1

node/multiClient: Add node address to errors #1428

Merged
fyrchik merged 1 commit from achuprov/frostfs-node:feat/multiClient_node_address into master 2024-10-15 14:05:34 +00:00
Conversation 0 Commits 1 Files changed 1 +5 -4
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit ef2808c687 - Show all commits

9
pkg/network/cache/multi.go vendored
View file

@ -169,15 +169,16 @@ func (x *multiClient) iterateClients(ctx context.Context, f func(clientcore.Clie
var siErr *objectSDK.SplitInfoError var siErr *objectSDK.SplitInfoError
var eiErr *objectSDK.ECInfoError var eiErr *objectSDK.ECInfoError
if err != nil {
err = fmt.Errorf("client connection error at %v: %w", addr, err)
fyrchik commented 2024-10-14 11:22:40 +00:00
Outdated
Review
Copy link

What does client error mean in logs?

What does `client error` mean in logs?
fyrchik commented 2024-10-14 15:19:21 +00:00
Outdated
Review
Copy link

how about connect to %v: %w
I am sure the error will already be mentioned multiple times in the full message.

how about `connect to %v: %w` I am sure the `error` will already be mentioned multiple times in the full message.
x.ReportError(err)
}
success := err == nil || errors.Is(err, context.Canceled) || errors.As(err, &siErr) || errors.As(err, &eiErr) success := err == nil || errors.Is(err, context.Canceled) || errors.As(err, &siErr) || errors.As(err, &eiErr)
if success || firstErr == nil || errors.Is(firstErr, errRecentlyFailed) { if success || firstErr == nil || errors.Is(firstErr, errRecentlyFailed) {
firstErr = err firstErr = err
} }
if err != nil {
x.ReportError(err)
}
return success return success
}) })