TrueCloudLab/frostfs-node
21
1
Fork 27
Code Issues 104 Pull requests 4 Projects Releases 2 Activity Actions

container: Reduce iterations through container list #1577

Merged
fyrchik merged 3 commits from elebedeva/frostfs-node:feat/container-batching into master 2024-12-28 10:05:35 +00:00
Conversation 0 Commits 3 Files changed 6 +2 -2
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit c0221d76e6 - Show all commits

2
cmd/frostfs-node/config/container/container.go
View file

@ -6,7 +6,7 @@ const (
subsection = "container" subsection = "container"
listStreamSubsection = "list_stream" listStreamSubsection = "list_stream"
// ContainerBatchSizeDefault represents he maximum amount of containers to send via stream at once. // ContainerBatchSizeDefault represents the maximum amount of containers to send via stream at once.
ContainerBatchSizeDefault = 1000 ContainerBatchSizeDefault = 1000
) )

2
pkg/morph/client/container/containers_of.go
View file

@ -36,7 +36,6 @@ func (c *Client) IterateContainersOf(idUser *user.ID, cb func(item cid.ID) error
rawID = idUser.WalletBytes() rawID = idUser.WalletBytes()
} }
cnrHash := c.client.ContractAddress()
itemCb := func(item stackitem.Item) error { itemCb := func(item stackitem.Item) error {
fyrchik commented 2024-12-28 05:43:36 +00:00
Review
Copy link

This line was right before the TestInvokeIterator previously, why has it moved?

This line was right before the `TestInvokeIterator` previously, why has it moved?
elebedeva commented 2024-12-28 09:03:08 +00:00
Review
Copy link

Accidentally. Moved it back.

Accidentally. Moved it back.
id, err := getCIDfromStackItem(item) id, err := getCIDfromStackItem(item)
if err != nil { if err != nil {
@ -57,6 +56,7 @@ func (c *Client) IterateContainersOf(idUser *user.ID, cb func(item cid.ID) error
// 512 is big enough value and it is beautiful. // 512 is big enough value and it is beautiful.
const batchSize = 512 const batchSize = 512
cnrHash := c.client.ContractAddress()
err := c.client.Morph().TestInvokeIterator(itemCb, batchSize, cnrHash, containersOfMethod, rawID) err := c.client.Morph().TestInvokeIterator(itemCb, batchSize, cnrHash, containersOfMethod, rawID)
if err != nil && errors.Is(err, unwrap.ErrNoSessionID) { if err != nil && errors.Is(err, unwrap.ErrNoSessionID) {
return c.iterate(idUser, cb) return c.iterate(idUser, cb)