TrueCloudLab/frostfs-node
20
1
Fork 28
Code Issues 112 Pull requests 3 Projects Releases 2 Activity Actions

frostfs-adm: Return non zero return code if metabase upgrade failed #1622

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-node:fix/metabase_upgrade_non_zero_return_code into master 2025-01-30 13:01:27 +00:00
Conversation 0 Commits 1 Files changed 1 +7 -1
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
cmd/frostfs-adm/internal/modules/metabase/upgrade.go
View file

@ -28,6 +28,7 @@ const (
var ( var (
errNoPathsFound = errors.New("no metabase paths found") errNoPathsFound = errors.New("no metabase paths found")
errNoMorphEndpointsFound = errors.New("no morph endpoints found") errNoMorphEndpointsFound = errors.New("no morph endpoints found")
errUpgradeFailed = errors.New("upgrade failed")
) )
var UpgradeCmd = &cobra.Command{ var UpgradeCmd = &cobra.Command{
@ -91,15 +92,20 @@ func upgrade(cmd *cobra.Command, _ []string) error {
if err := eg.Wait(); err != nil { if err := eg.Wait(); err != nil {
return err return err
} }
allSuccess := true
for mb, ok := range result { for mb, ok := range result {
if ok { if ok {
cmd.Println(mb, ": success") cmd.Println(mb, ": success")
} else { } else {
cmd.Println(mb, ": failed") cmd.Println(mb, ": failed")
allSuccess = false
} }
} }
if allSuccess {
return nil return nil
} }
return errUpgradeFailed
}
func getMetabasePaths(appCfg *config.Config) ([]string, error) { func getMetabasePaths(appCfg *config.Config) ([]string, error) {
var paths []string var paths []string