TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 100 Pull requests 4 Projects Releases 1 Activity Actions

Refactor metrics #213

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-node:refactoring/object-3610-metrics into master 2023-07-26 21:07:57 +00:00
Conversation 0 Commits 1 Files changed 1 +47 -115
dstepanov-yadro commented 2023-04-05 09:46:55 +00:00
Member
Copy link

Resolve funlen linters.

Resolve funlen linters.
dstepanov-yadro force-pushed refactoring/object-3610-metrics from a966fe240d to 1a1f8d1c7f 2023-04-05 09:47:46 +00:00 Compare
dstepanov-yadro requested review from storage-core-committers 2023-04-05 09:47:54 +00:00
dstepanov-yadro requested review from storage-core-developers 2023-04-05 09:47:54 +00:00
fyrchik reviewed 2023-04-05 11:10:14 +00:00
pkg/metrics/engine.go Outdated
@ -120,3 +30,1 @@
Help: "Accumulated size of all objects in a shard",
}, []string{shardIDLabelKey})
)
var ()
fyrchik commented 2023-04-05 11:06:28 +00:00
Owner
Copy link

Hm

Hm
😕 1
dstepanov-yadro commented 2023-04-05 12:22:23 +00:00
Author
Member
Copy link

fixed

fixed
fyrchik marked this conversation as resolved
pkg/metrics/engine.go Outdated
@ -138,3 +46,4 @@
}
}
func getListContainersDurationEngCounter() prometheus.Counter {
fyrchik commented 2023-04-05 11:08:42 +00:00
Owner
Copy link

It feels a bit klunky, what about using engineMetric("list_containers_duration", "Accumulated duration of engine list containers operations") at the call site?

I think there is no need to duplicate namespace and subsystem in each function and without the it isn't worth to have a separate function.

It feels a bit klunky, what about using `engineMetric("list_containers_duration", "Accumulated duration of engine list containers operations")` at the call site? I think there is no need to duplicate namespace and subsystem in each function and without the it isn't worth to have a separate function.
fyrchik commented 2023-04-05 11:10:05 +00:00
Owner
Copy link

Also, some of them follow the same pattern both in name and help.

Also, some of them follow the same pattern both in name and help.
dstepanov-yadro commented 2023-04-05 12:23:15 +00:00
Author
Member
Copy link

Fixed

Fixed
fyrchik marked this conversation as resolved
pkg/metrics/object.go Outdated
@ -95,2 +79,2 @@
Help: "Accumulated get request process duration",
})
return objectServiceMetrics{
getCounter: newMethodCallCounter("get"),
fyrchik commented 2023-04-05 11:09:28 +00:00
Owner
Copy link

We have duration for all methods, what about combining them together, inside newMethodCallCounter?

We have duration for all methods, what about combining them together, inside `newMethodCallCounter`?
dstepanov-yadro commented 2023-04-05 12:24:41 +00:00
Author
Member
Copy link

I didn't catch the thought. duration and call counter are different metrics.

I didn't catch the thought. `duration` and `call counter` are different metrics.
fyrchik commented 2023-04-05 13:54:15 +00:00
Owner
Copy link

Yes, but they all are generic and parametrized by method.
So, maybe not newMethodCallCounter, but newMethodCallMetrics?

Yes, but they all are generic and parametrized by method. So, maybe not `newMethodCallCounter`, but `newMethodCallMetrics`?
dstepanov-yadro commented 2023-04-05 14:21:34 +00:00
Author
Member
Copy link

Done.

newMethodCallMetrics - too general, metrics can be different.

Done. ```newMethodCallMetrics``` - too general, metrics can be different.
fyrchik marked this conversation as resolved
dstepanov-yadro force-pushed refactoring/object-3610-metrics from 1a1f8d1c7f to c8a8765046 2023-04-05 12:22:00 +00:00 Compare
dstepanov-yadro force-pushed refactoring/object-3610-metrics from c8a8765046 to 9172573c54 2023-04-05 13:01:53 +00:00 Compare
aarifullin approved these changes 2023-04-05 13:39:13 +00:00
aarifullin left a comment
Member
Copy link

LGTM

LGTM
dstepanov-yadro force-pushed refactoring/object-3610-metrics from 9172573c54 to c6fc3a7f4c 2023-04-05 14:20:14 +00:00 Compare
dstepanov-yadro force-pushed refactoring/object-3610-metrics from c6fc3a7f4c to 02f2ebd890 2023-04-05 14:55:45 +00:00 Compare
dstepanov-yadro reviewed 2023-04-07 14:20:01 +00:00
pkg/metrics/engine.go Outdated
@ -136,2 +33,2 @@
containerSize: *containerSize,
payloadSize: *payloadSize,
listContainersDuration: newEngineMethodDurationCounter("list_containers_"),
estimateContainerSizeDuration: newEngineCounter("estimate_container_size_duration", "Accumulated duration of engine container size estimate operations"),
dstepanov-yadro commented 2023-04-07 14:20:01 +00:00
Author
Member
Copy link

Different word order in name and help.

Different word order in name and help.
dstepanov-yadro force-pushed refactoring/object-3610-metrics from 02f2ebd890 to 49142dc9eb 2023-04-07 14:21:06 +00:00 Compare
dstepanov-yadro force-pushed refactoring/object-3610-metrics from 49142dc9eb to 02831d427b 2023-04-10 06:43:46 +00:00 Compare
acid-ant approved these changes 2023-04-10 06:49:07 +00:00
fyrchik approved these changes 2023-04-10 07:32:47 +00:00
fyrchik merged commit 02831d427b into master 2023-04-10 07:32:59 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
acid-ant
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#213
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:refactoring/object-3610-metrics"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?