TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 105 Pull requests 13 Projects Releases 2 Activity Actions

Fixes for the morph client and neofs-adm #239

Merged
fyrchik merged 6 commits from fyrchik/frostfs-node:some-fixes into master 2023-04-13 13:15:32 +00:00
Conversation 0 Commits 6 Files changed 8 +10 -1
2 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit fdc585382d - Show all commits

1
CHANGELOG.md
View file

@ -56,6 +56,7 @@ Changelog for FrostFS Node
- Parts of a locked object could not be removed anymore (#141) - Parts of a locked object could not be removed anymore (#141)
- Non-alphabet nodes do not try to handle alphabet events (#181) - Non-alphabet nodes do not try to handle alphabet events (#181)
- Failing SN and IR transactions because of incorrect scopes (#2230, #2263) - Failing SN and IR transactions because of incorrect scopes (#2230, #2263)
- Global scope used for some transactions (#2230, #2263)
### Removed ### Removed
### Updated ### Updated

10
pkg/morph/client/nns.go
View file

@ -208,10 +208,18 @@ func (c *Client) SetGroupSignerScope() error {
return err return err
} }
c.cfg.signer = &transaction.Signer{ // Don't change c before everything is OK.
cfg := c.cfg
cfg.signer = &transaction.Signer{
Scopes: transaction.CustomGroups | transaction.CalledByEntry, Scopes: transaction.CustomGroups | transaction.CalledByEntry,
dstepanov-yadro commented 2023-04-13 07:56:47 +00:00
Review
Copy link

Scopes changed. Is it ok?

Scopes changed. Is it ok?
fyrchik commented 2023-04-13 09:21:04 +00:00
Review
Copy link

Yes, it is similar to fix in another commit.

Yes, it is similar to fix in another commit.
AllowedGroups: []*keys.PublicKey{pub}, AllowedGroups: []*keys.PublicKey{pub},
} }
rpcActor, err := newActor(c.client, c.acc, cfg)
if err != nil {
return err
}
c.cfg = cfg
c.setActor(rpcActor)
return nil return nil
} }