TrueCloudLab/frostfs-node
20
1
Fork 28
Code Issues 108 Pull requests 4 Projects Releases 2 Activity Actions 1

Fix/WC init race condition #261

Merged
fyrchik merged 1 commit from fix/races-in-WC into master 2023-04-19 09:29:08 +00:00
Conversation 0 Commits 1 Files changed 1 +8
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
pkg/local_object_storage/writecache/init.go
View file

@ -86,13 +86,21 @@ func (c *cache) fsTreeFlushMarkUpdate(ctx context.Context) {
} }
return nil return nil
} }
c.modeMtx.RLock()
defer c.modeMtx.RUnlock()
fyrchik commented 2023-04-18 07:54:41 +00:00
Outdated
Review
Copy link

Why not defer?

Why not `defer`?
carpawell commented 2023-04-18 14:49:20 +00:00
Outdated
Review
Copy link

wanted it to unlock as fast as possible, without logging and other (possible in future) things. changed to be deferred

wanted it to unlock as fast as possible, without logging and other (possible in future) things. changed to be deferred
_, _ = c.fsTree.Iterate(prm) _, _ = c.fsTree.Iterate(prm)
c.log.Info(logs.WritecacheFinishedUpdatingFSTreeFlushMarks) c.log.Info(logs.WritecacheFinishedUpdatingFSTreeFlushMarks)
} }
func (c *cache) dbFlushMarkUpdate(ctx context.Context) { func (c *cache) dbFlushMarkUpdate(ctx context.Context) {
c.log.Info(logs.WritecacheFillingFlushMarksForObjectsInDatabase) c.log.Info(logs.WritecacheFillingFlushMarksForObjectsInDatabase)
c.modeMtx.RLock()
defer c.modeMtx.RUnlock()
var m []string var m []string
var indices []int var indices []int
var lastKey []byte var lastKey []byte