.forgejo/workflows/tests.yml

@@ -14,10 +14,11 @@ jobs:
           go-version: '1.21'
           cache: true
 
-      - name: golangci-lint
+      - name: Install linters
-        uses: https://github.com/golangci/golangci-lint-action@v3
+        run: make lint-install
-        with:
+
-          version: latest
+      - name: Run linters
+        run: make lint
 
   tests:
     name: Tests

.golangci.yml

@@ -37,6 +37,14 @@ linters-settings:
     alias:
       pkg: git.frostfs.info/TrueCloudLab/frostfs-sdk-go/object
       alias: objectSDK
+  custom:
+    noliteral:
+      path: bin/external_linters.so
+      original-url: git.frostfs.info/TrueCloudLab/linters.git 
+      settings:
+        target-methods : ["reportFlushError", "reportError"]
+        disable-packages: ["codes", "err", "res","exec"]
+        constants-package: "git.frostfs.info/TrueCloudLab/frostfs-node/internal/logs"
 
 linters:
   enable:
@@ -69,5 +77,6 @@ linters:
     - gocognit
     - contextcheck
     - importas
+    - noliteral
   disable-all: true
   fast: false

Makefile

@@ -8,7 +8,7 @@ HUB_IMAGE ?= truecloudlab/frostfs
 HUB_TAG ?= "$(shell echo ${VERSION} | sed 's/^v//')"
 
 GO_VERSION ?= 1.21
-LINT_VERSION ?= 1.52.2
+LINT_VERSION ?= 1.54.0
 ARCH = amd64
 
 BIN = bin
@@ -25,6 +25,10 @@ PKG_VERSION ?= $(shell echo $(VERSION) | sed "s/^v//" | \
 			sed -E "s/(.*)-(g[a-fA-F0-9]{6,8})(.*)/\1\3~\2/" | \
 			sed "s/-/~/")-${OS_RELEASE}
 
+OUTPUT_LINT_DIR ?= $(shell pwd)/bin
+LINT_DIR = $(OUTPUT_LINT_DIR)/golangci-lint-$(LINT_VERSION)
+TMP_DIR := .cache
+
 .PHONY: help all images dep clean fmts fmt imports test lint docker/lint
 		prepare-release debpackage pre-commit unpre-commit
 
@@ -131,9 +135,23 @@ test:
 pre-commit-run:
 	@pre-commit run -a --hook-stage manual
 
+# Install linters
+lint-install:
+	@mkdir -p $(TMP_DIR)
+	@rm -rf $(TMP_DIR)/linters
+	@git clone --depth 1 https://git.frostfs.info/TrueCloudLab/linters.git $(TMP_DIR)/linters
+	@@make -C $(TMP_DIR)/linters lib CGO_ENABLED=1 OUT_DIR=$(OUTPUT_LINT_DIR)
+	@rm -rf $(TMP_DIR)/linters
+	@rmdir $(TMP_DIR) 2>/dev/null || true
+	@CGO_ENABLED=1 GOBIN=$(LINT_DIR) go install github.com/golangci/golangci-lint/cmd/golangci-lint@v$(LINT_VERSION)
+
 # Run linters
 lint:
-	@golangci-lint --timeout=5m run
+	@if [ ! -d "$(LINT_DIR)" ]; then \
+		echo "Run make lint-install"; \
+		exit 1; \
+	fi
+	$(LINT_DIR)/golangci-lint run
 
 # Install staticcheck
 staticcheck-install:

cmd/frostfs-node/netmap.go

@@ -333,7 +333,7 @@ func (c *cfg) netmapInitLocalNodeState(epoch uint64) (*netmapSDK.NodeInfo, bool,
 	if nmState != candidateState {
 		// This happens when the node was switched to maintenance without epoch tick.
 		// We expect it to continue staying in maintenance.
-		c.log.Info("candidate status is different from the netmap status, the former takes priority",
+		c.log.Info(logs.CandidateStatusPriority,
 			zap.String("netmap", nmState),
 			zap.String("candidate", candidateState))
 	}

internal/logs/logs.go

@@ -495,6 +495,22 @@ const (
 	FrostFSNodeNodeIsUnderMaintenanceSkipInitialBootstrap                   = "the node is under maintenance, skip initial bootstrap"
 	EngineCouldNotChangeShardModeToDisabled                                 = "could not change shard mode to disabled"
 	NetmapNodeAlreadyInCandidateListOnlineSkipInitialBootstrap              = "the node is already in candidate list with online state, skip initial bootstrap"
+	RPConnectionLost                                                        = "RPC connection lost, attempting reconnect"
+	RPCNodeSwitchFailure                                                    = "can't switch RPC node"
+	FSTreeCantReadFile                                                      = "can't read a file"
+	FSTreeCantUnmarshalObject                                               = "can't unmarshal an object"
+	FSTreeCantFushObjectBlobstor                                            = "can't flush an object to blobstor"
+	FSTreeCantUpdateID                                                      = "can't update object storage ID"
+	FSTreeCantDecodeDBObjectAddress                                         = "can't decode object address from the DB"
+	PutSingleRedirectFailure                                                = "failed to redirect PutSingle request"
+	StorageIDRetrievalFailure                                               = "can't get storage ID from metabase"
+	ObjectRemovalFailureBlobStor                                            = "can't remove object from blobStor"
+	CandidateStatusPriority                                                 = "candidate status is different from the netmap status, the former takes priority"
+	TombstoneExpirationParseFailure                                         = "tombstone getter: could not parse tombstone expiration epoch"
+	FrostFSNodeCantUpdateObjectStorageID                                    = "can't update object storage ID"
+	FrostFSNodeCantFlushObjectToBlobstor                                    = "can't flush an object to blobstor"
+	FrostFSNodeCantDecodeObjectAddressFromDB                                = "can't decode object address from the DB" // Error in ../node/cmd/frostfs-node/morph.go
+	FrostFSNodeCantUnmarshalObjectFromDB                                    = "can't unmarshal an object from the DB"   // Error in ../node/cmd/frostfs-node/morph.go
 	RuntimeSoftMemoryLimitUpdated                                           = "soft runtime memory limit value updated"
 	RuntimeSoftMemoryDefinedWithGOMEMLIMIT                                  = "soft runtime memory defined with GOMEMLIMIT environment variable, config value skipped"
 )

pkg/local_object_storage/shard/delete.go

@@ -92,7 +92,7 @@ func (s *Shard) deleteFromBlobstorSafe(ctx context.Context, addr oid.Address) {
 
 	res, err := s.metaBase.StorageID(ctx, sPrm)
 	if err != nil {
-		s.log.Debug("can't get storage ID from metabase",
+		s.log.Debug(logs.StorageIDRetrievalFailure,
 			zap.Stringer("object", addr),
 			zap.String("error", err.Error()))
 	}
@@ -104,7 +104,7 @@ func (s *Shard) deleteFromBlobstorSafe(ctx context.Context, addr oid.Address) {
 
 	_, err = s.blobStor.Delete(ctx, delPrm)
 	if err != nil {
-		s.log.Debug("can't remove object from blobStor",
+		s.log.Debug(logs.ObjectRemovalFailureBlobStor,
 			zap.Stringer("object_address", addr),
 			zap.String("error", err.Error()))
 	}

pkg/local_object_storage/writecache/writecachebadger/flush.go

@@ -188,7 +188,7 @@ func (c *cache) flushObject(ctx context.Context, obj *objectSDK.Object, data []b
 	if err != nil {
 		if !errors.Is(err, common.ErrNoSpace) && !errors.Is(err, common.ErrReadOnly) &&
 			!errors.Is(err, blobstor.ErrNoPlaceFound) {
-			c.reportFlushError("can't flush an object to blobstor",
+			c.reportFlushError(logs.FrostFSNodeCantFlushObjectToBlobstor,
 				addr.EncodeToString(), err)
 		}
 		return err
@@ -200,7 +200,7 @@ func (c *cache) flushObject(ctx context.Context, obj *objectSDK.Object, data []b
 
 	_, err = c.metabase.UpdateStorageID(updPrm)
 	if err != nil {
-		c.reportFlushError("can't update object storage ID",
+		c.reportFlushError(logs.FrostFSNodeCantUpdateObjectStorageID,
 			addr.EncodeToString(), err)
 	}
 	return err
@@ -230,7 +230,7 @@ func (c *cache) flush(ctx context.Context, ignoreErrors bool) error {
 		for it.Rewind(); it.Valid(); it.Next() {
 			if got, want := int(it.Item().KeySize()), len(key); got != want {
 				err := fmt.Errorf("invalid db key len: got %d, want %d", got, want)
-				c.reportFlushError("can't decode object address from the DB", hex.EncodeToString(it.Item().Key()), metaerr.Wrap(err))
+				c.reportFlushError(logs.FrostFSNodeCantDecodeObjectAddressFromDB, hex.EncodeToString(it.Item().Key()), metaerr.Wrap(err))
 				if ignoreErrors {
 					continue
 				}
@@ -240,7 +240,7 @@ func (c *cache) flush(ctx context.Context, ignoreErrors bool) error {
 				var obj objectSDK.Object
 				if err := obj.Unmarshal(data); err != nil {
 					copy(key[:], it.Item().Key())
-					c.reportFlushError("can't unmarshal an object from the DB", key.address().EncodeToString(), metaerr.Wrap(err))
+					c.reportFlushError(logs.FrostFSNodeCantUnmarshalObjectFromDB, key.address().EncodeToString(), metaerr.Wrap(err))
 					if ignoreErrors {
 						return nil
 					}

pkg/local_object_storage/writecache/writecachebbolt/flush.go

@@ -194,7 +194,7 @@ func (c *cache) flushFSTree(ctx context.Context, ignoreErrors bool) error {
 
 		data, err := f()
 		if err != nil {
-			c.reportFlushError("can't read a file", sAddr, metaerr.Wrap(err))
+			c.reportFlushError(logs.FSTreeCantReadFile, sAddr, metaerr.Wrap(err))
 			if ignoreErrors {
 				return nil
 			}
@@ -204,7 +204,7 @@ func (c *cache) flushFSTree(ctx context.Context, ignoreErrors bool) error {
 		var obj objectSDK.Object
 		err = obj.Unmarshal(data)
 		if err != nil {
-			c.reportFlushError("can't unmarshal an object", sAddr, metaerr.Wrap(err))
+			c.reportFlushError(logs.FSTreeCantUnmarshalObject, sAddr, metaerr.Wrap(err))
 			if ignoreErrors {
 				return nil
 			}
@@ -268,7 +268,7 @@ func (c *cache) flushObject(ctx context.Context, obj *objectSDK.Object, data []b
 	if err != nil {
 		if !errors.Is(err, common.ErrNoSpace) && !errors.Is(err, common.ErrReadOnly) &&
 			!errors.Is(err, blobstor.ErrNoPlaceFound) {
-			c.reportFlushError("can't flush an object to blobstor",
+			c.reportFlushError(logs.FSTreeCantFushObjectBlobstor,
 				addr.EncodeToString(), err)
 		}
 		return err
@@ -280,7 +280,7 @@ func (c *cache) flushObject(ctx context.Context, obj *objectSDK.Object, data []b
 
 	_, err = c.metabase.UpdateStorageID(updPrm)
 	if err != nil {
-		c.reportFlushError("can't update object storage ID",
+		c.reportFlushError(logs.FSTreeCantUpdateID,
 			addr.EncodeToString(), err)
 	}
 	return err
@@ -315,7 +315,7 @@ func (c *cache) flush(ctx context.Context, ignoreErrors bool) error {
 		for k, data := cs.Seek(nil); k != nil; k, data = cs.Next() {
 			sa := string(k)
 			if err := addr.DecodeString(sa); err != nil {
-				c.reportFlushError("can't decode object address from the DB", sa, metaerr.Wrap(err))
+				c.reportFlushError(logs.FSTreeCantDecodeDBObjectAddress, sa, metaerr.Wrap(err))
 				if ignoreErrors {
 					continue
 				}
@@ -324,7 +324,7 @@ func (c *cache) flush(ctx context.Context, ignoreErrors bool) error {
 
 			var obj objectSDK.Object
 			if err := obj.Unmarshal(data); err != nil {
-				c.reportFlushError("can't unmarshal an object from the DB", sa, metaerr.Wrap(err))
+				c.reportFlushError(logs.FSTreeCantDecodeDBObjectAddress, sa, metaerr.Wrap(err))
 				if ignoreErrors {
 					continue
 				}

pkg/morph/subscriber/subscriber.go

@@ -250,9 +250,9 @@ routeloop:
 }
 
 func (s *subscriber) switchEndpoint(ctx context.Context, finishCh chan<- bool) (bool, <-chan rpcclient.Notification) {
-	s.log.Info("RPC connection lost, attempting reconnect")
+	s.log.Info(logs.RPConnectionLost)
 	if !s.client.SwitchRPC(ctx) {
-		s.log.Error("can't switch RPC node")
+		s.log.Error(logs.RPCNodeSwitchFailure)
 		return false, nil
 	}
 

pkg/services/object/put/single.go

@@ -343,7 +343,7 @@ func (s *Service) redirectPutSingleRequest(ctx context.Context,
 			if err != nil {
 				objID, _ := obj.ID()
 				cnrID, _ := obj.ContainerID()
-				s.log.Warn("failed to redirect PutSingle request",
+				s.log.Warn(logs.PutSingleRedirectFailure,
 					zap.Error(err),
 					zap.Stringer("address", addr),
 					zap.Stringer("object_id", objID),

pkg/services/object_manager/tombstone/checker.go

@@ -78,7 +78,7 @@ func (g *ExpirationChecker) handleTS(addr string, ts *objectSDK.Object, reqEpoch
 			epoch, err := strconv.ParseUint(atr.Value(), 10, 64)
 			if err != nil {
 				g.log.Warn(
-					"tombstone getter: could not parse tombstone expiration epoch",
+					logs.TombstoneExpirationParseFailure,
 					zap.Error(err),
 				)