TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 96 Pull requests 4 Projects Releases 1 Activity Actions

Fix epoch metric #773

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-node:fix/epoch_metric into master 2023-11-01 10:57:32 +00:00
Conversation 0 Commits 1 Files changed 1 +2 -1
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
cmd/frostfs-node/config.go
View file

@ -562,10 +562,11 @@ func initCfg(appCfg *config.Config) *cfg {
relayOnly := nodeconfig.Relay(appCfg) relayOnly := nodeconfig.Relay(appCfg)
fyrchik marked this conversation as resolved Outdated
fyrchik commented 2023-11-01 10:06:00 +00:00
Outdated
Review
Copy link

So we partially initialize netState because we need it in initShared and then finalize netState initialization.
The same problem with metrics can happen inside initShared
To me the problem is that initialization order in code does not match real order.
What about initializing metrics first somewhere? Or is it too much work?

So we partially initialize `netState` because we need it in `initShared` and then finalize `netState` initialization. The same problem with metrics can happen inside `initShared` To me the problem is that initialization order in code does not match real order. What about initializing metrics first somewhere? Or is it too much work?
dstepanov-yadro commented 2023-11-01 10:44:19 +00:00
Outdated
Review
Copy link

shared holds metrics, so looks like metrics are initialized correctly. Also cfgNetmap holds netstate, so it also looks ok for me. So i don't think it should be refactored.

`shared` holds metrics, so looks like metrics are initialized correctly. Also `cfgNetmap` holds `netstate`, so it also looks ok for me. So i don't think it should be refactored.
👍 1
netState := newNetworkState() netState := newNetworkState()
netState.metrics = c.metricsCollector
c.shared = initShared(appCfg, key, netState, relayOnly) c.shared = initShared(appCfg, key, netState, relayOnly)
netState.metrics = c.metricsCollector
logPrm, err := c.loggerPrm() logPrm, err := c.loggerPrm()
fatalOnErr(err) fatalOnErr(err)
logPrm.SamplingHook = c.metricsCollector.LogMetrics().GetSamplingHook() logPrm.SamplingHook = c.metricsCollector.LogMetrics().GetSamplingHook()