Ekaterina Lebedeva
a685fcdc96
All checks were successful
DCO action / DCO (pull_request) Successful in 2m41s
Tests and linters / Run gofumpt (pull_request) Successful in 2m32s
Vulncheck / Vulncheck (pull_request) Successful in 2m38s
Build / Build Components (1.23) (pull_request) Successful in 3m0s
Build / Build Components (1.22) (pull_request) Successful in 3m3s
Pre-commit hooks / Pre-commit (pull_request) Successful in 3m33s
Tests and linters / Tests (1.22) (pull_request) Successful in 3m34s
Tests and linters / Tests (1.23) (pull_request) Successful in 3m36s
Tests and linters / Staticcheck (pull_request) Successful in 3m35s
Tests and linters / Lint (pull_request) Successful in 4m18s
Tests and linters / Tests with -race (pull_request) Successful in 4m20s
Tests and linters / gopls check (pull_request) Successful in 4m25s
Since Go 1.22 a "for" statement with a "range" clause is able
to iterate through integer values from zero to an upper limit.
gopatch script:
@@
var i, e expression
@@
-for i := 0; i <= e - 1; i++ {
+for i := range e {
...
}
@@
var i, e expression
@@
-for i := 0; i <= e; i++ {
+for i := range e + 1 {
...
}
@@
var i, e expression
@@
-for i := 0; i < e; i++ {
+for i := range e {
...
}
Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>
94 lines
2.7 KiB
Go
94 lines
2.7 KiB
Go
package placement_test
|
|
|
|
import (
|
|
"strconv"
|
|
"testing"
|
|
|
|
"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/services/object_manager/placement"
|
|
cid "git.frostfs.info/TrueCloudLab/frostfs-sdk-go/container/id"
|
|
cidtest "git.frostfs.info/TrueCloudLab/frostfs-sdk-go/container/id/test"
|
|
netmapSDK "git.frostfs.info/TrueCloudLab/frostfs-sdk-go/netmap"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestContainerNodesCache(t *testing.T) {
|
|
const size = 3
|
|
|
|
nodes := [6]netmapSDK.NodeInfo{}
|
|
for i := range nodes {
|
|
nodes[i].SetAttribute("ATTR", strconv.Itoa(i))
|
|
}
|
|
|
|
nm := func(epoch uint64, nodes []netmapSDK.NodeInfo) *netmapSDK.NetMap {
|
|
var nm netmapSDK.NetMap
|
|
nm.SetEpoch(epoch)
|
|
nm.SetNodes(nodes)
|
|
return &nm
|
|
}
|
|
|
|
var pp netmapSDK.PlacementPolicy
|
|
require.NoError(t, pp.DecodeString("REP 1"))
|
|
|
|
t.Run("update netmap on the new epoch", func(t *testing.T) {
|
|
c := placement.NewContainerNodesCache(size)
|
|
|
|
cnr := cidtest.ID()
|
|
res, err := c.ContainerNodes(nm(1, nodes[0:1]), cnr, pp)
|
|
require.NoError(t, err)
|
|
|
|
// Use other nodes in the argument to ensure the result is taken from cache.
|
|
resCached, err := c.ContainerNodes(nm(1, nodes[1:2]), cnr, pp)
|
|
require.NoError(t, err)
|
|
require.Equal(t, res, resCached)
|
|
|
|
// Update epoch, netmap should be purged.
|
|
resCached, err = c.ContainerNodes(nm(2, nodes[2:3]), cnr, pp)
|
|
require.NoError(t, err)
|
|
require.NotEqual(t, res, resCached)
|
|
})
|
|
t.Run("cache uses container as a key", func(t *testing.T) {
|
|
c := placement.NewContainerNodesCache(size)
|
|
|
|
res1, err := c.ContainerNodes(nm(1, nodes[0:1]), cidtest.ID(), pp)
|
|
require.NoError(t, err)
|
|
|
|
res2, err := c.ContainerNodes(nm(1, nodes[1:2]), cidtest.ID(), pp)
|
|
require.NoError(t, err)
|
|
|
|
require.NotEqual(t, res1, res2)
|
|
})
|
|
t.Run("cache respects size parameter", func(t *testing.T) {
|
|
c := placement.NewContainerNodesCache(size)
|
|
|
|
nm1 := nm(1, nodes[0:1])
|
|
nm2 := nm(1, nodes[1:2])
|
|
cnr := [size * 2]cid.ID{}
|
|
res := [size * 2][][]netmapSDK.NodeInfo{}
|
|
for i := range size * 2 {
|
|
cnr[i] = cidtest.ID()
|
|
|
|
var err error
|
|
res[i], err = c.ContainerNodes(nm1, cnr[i], pp)
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
for i := size; i < size*2; i++ {
|
|
r, err := c.ContainerNodes(nm2, cnr[i], pp)
|
|
require.NoError(t, err)
|
|
require.Equal(t, res[i], r)
|
|
}
|
|
for i := range size {
|
|
r, err := c.ContainerNodes(nm2, cnr[i], pp)
|
|
require.NoError(t, err)
|
|
require.NotEqual(t, res[i], r)
|
|
}
|
|
})
|
|
t.Run("the error is propagated", func(t *testing.T) {
|
|
var pp netmapSDK.PlacementPolicy
|
|
require.NoError(t, pp.DecodeString("REP 1 SELECT 1 FROM X FILTER ATTR EQ 42 AS X"))
|
|
|
|
c := placement.NewContainerNodesCache(size)
|
|
_, err := c.ContainerNodes(nm(1, nodes[0:1]), cidtest.ID(), pp)
|
|
require.Error(t, err)
|
|
})
|
|
}
|