34544502dc
All checks were successful
ci/woodpecker/pr/pre-commit Pipeline was successful
Do not use write-cache as a read cache: always remove objects from the WC, not only if an object hasn't been used for some time (LRU cache is dropped). Use object size (in bytes) as a metric of used space, not an approximate (and too inaccurate) maximum stored objects number. Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
86 lines
2.4 KiB
Go
86 lines
2.4 KiB
Go
package writecache
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
|
|
"git.frostfs.info/TrueCloudLab/frostfs-api-go/v2/pkg/tracing"
|
|
"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/blobstor/common"
|
|
storagelog "git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/internal/log"
|
|
apistatus "git.frostfs.info/TrueCloudLab/frostfs-sdk-go/client/status"
|
|
oid "git.frostfs.info/TrueCloudLab/frostfs-sdk-go/object/id"
|
|
"go.etcd.io/bbolt"
|
|
"go.opentelemetry.io/otel/attribute"
|
|
"go.opentelemetry.io/otel/trace"
|
|
)
|
|
|
|
// Delete removes object from write-cache.
|
|
//
|
|
// Returns an error of type apistatus.ObjectNotFound if object is missing in write-cache.
|
|
func (c *Cache) Delete(ctx context.Context, addr oid.Address) error {
|
|
ctx, span := tracing.StartSpanFromContext(ctx, "writecache.Delete",
|
|
trace.WithAttributes(
|
|
attribute.String("address", addr.EncodeToString()),
|
|
))
|
|
defer span.End()
|
|
|
|
c.modeMtx.RLock()
|
|
defer c.modeMtx.RUnlock()
|
|
if c.readOnly() {
|
|
return ErrReadOnly
|
|
}
|
|
|
|
saddr := addr.EncodeToString()
|
|
|
|
// Check disk cache.
|
|
var valLen int
|
|
_ = c.db.View(func(tx *bbolt.Tx) error {
|
|
b := tx.Bucket(defaultBucket)
|
|
valLen = len(b.Get([]byte(saddr)))
|
|
return nil
|
|
})
|
|
|
|
if valLen > 0 {
|
|
err := c.db.Update(func(tx *bbolt.Tx) error {
|
|
b := tx.Bucket(defaultBucket)
|
|
err := b.Delete([]byte(saddr))
|
|
return err
|
|
})
|
|
if err != nil {
|
|
return err
|
|
}
|
|
storagelog.Write(c.log,
|
|
storagelog.AddressField(saddr),
|
|
storagelog.StorageTypeField(wcStorageType),
|
|
storagelog.OpField("db DELETE"),
|
|
)
|
|
c.objCounters.decDB(valLen)
|
|
return nil
|
|
}
|
|
|
|
// While getting an object looks overheadly, it allows to
|
|
// get its size correctly without any additional memory/disk/CPU
|
|
// usage on the WC's side _for every object_. `Delete` is not
|
|
// expected to be called right after an object is put to the
|
|
// Write-cache often, and for non-existing objects (persisted
|
|
// to the main storage and dropped from the WC's storage) it
|
|
// is `os.Stat` vs `os.Remove` calls after all.
|
|
res, err := c.fsTree.Get(ctx, common.GetPrm{Address: addr})
|
|
if errors.As(err, new(apistatus.ObjectNotFound)) {
|
|
return nil
|
|
} else if err != nil {
|
|
return err
|
|
}
|
|
|
|
_, err = c.fsTree.Delete(ctx, common.DeletePrm{Address: addr})
|
|
if err == nil {
|
|
storagelog.Write(c.log,
|
|
storagelog.AddressField(saddr),
|
|
storagelog.StorageTypeField(wcStorageType),
|
|
storagelog.OpField("fstree DELETE"),
|
|
)
|
|
c.objCounters.decFS(len(res.RawData))
|
|
}
|
|
|
|
return err
|
|
}
|